RUST-679 Use error references to update topology

Author: saghm

src/client/executor.rs

@@ -103,7 +103,7 @@ impl Client {
             Err(err) => {
                 self.inner
                     .topology
-                    .handle_post_handshake_error(err.clone(), &conn, server)
+                    .handle_post_handshake_error(&err, &conn, server)
                     .await;
 
                 // Retryable writes are only supported by storage engines with document-level
@@ -162,7 +162,7 @@ impl Client {
             Err(err) => {
                 self.inner
                     .topology
-                    .handle_post_handshake_error(err.clone(), &conn, server)
+                    .handle_post_handshake_error(&err, &conn, server)
                     .await;
 
                 let err = match retryability {

src/sdam/monitor.rs

@@ -218,7 +218,7 @@ impl HeartbeatMonitor {
     }
 
     async fn handle_error(&mut self, error: Error, topology: &Topology, server: &Server) -> bool {
-        topology.handle_pre_handshake_error(error, server).await
+        topology.handle_pre_handshake_error(&error, server).await
     }
 }
 
@@ -250,9 +250,7 @@ impl UpdateMonitor {
                     error_generation,
                 } => {
                     if *error_generation == self.generation_subscriber.generation() {
-                        topology
-                            .handle_pre_handshake_error(error.clone(), &server)
-                            .await;
+                        topology.handle_pre_handshake_error(&error, &server).await;
                     }
                 }
             }

src/sdam/state/mod.rs

@@ -227,10 +227,10 @@ impl Topology {
 
     /// Updates the topology based on an error that occurs before the handshake has completed during
     /// an operation.
-    pub(crate) async fn handle_pre_handshake_error(&self, error: Error, server: &Server) -> bool {
+    pub(crate) async fn handle_pre_handshake_error(&self, error: &Error, server: &Server) -> bool {
         let state_lock = self.state.write().await;
         let changed = self
-            .mark_server_as_unknown(error, &server, state_lock)
+            .mark_server_as_unknown(&error, &server, state_lock)
             .await;
         if changed {
             server.pool.clear();
@@ -241,7 +241,7 @@ impl Topology {
     /// Handles an error that occurs after the handshake has completed during an operation.
     pub(crate) async fn handle_post_handshake_error(
         &self,
-        error: Error,
+        error: &Error,
         conn: &Connection,
         server: SelectedServer,
     ) {
@@ -255,7 +255,7 @@ impl Topology {
         } else if error.is_recovering() || error.is_not_master() {
             let state_lock = self.state.write().await;
 
-            self.mark_server_as_unknown(error.clone(), &server, state_lock)
+            self.mark_server_as_unknown(error, &server, state_lock)
                 .await;
 
             let wire_version = conn
@@ -279,7 +279,7 @@ impl Topology {
     /// Returns whether the topology changed as a result of the update.
     async fn mark_server_as_unknown(
         &self,
-        error: Error,
+        error: &Error,
         server: &Server,
         state_lock: RwLockWriteGuard<'_, TopologyState>,
     ) -> bool {