Skip to content

Commit 775b683

Browse files
authored
PYTHON-5371 - Pass repr(ServerDescription) to logging (#2329)
1 parent 5914ea0 commit 775b683

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

pymongo/asynchronous/topology.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
154154
_SDAM_LOGGER,
155155
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
156156
topologyId=self._topology_id,
157-
previousDescription=initial_td,
158-
newDescription=self._description,
157+
previousDescription=repr(initial_td),
158+
newDescription=repr(self._description),
159159
)
160160

161161
for seed in topology_settings.seeds:
@@ -514,8 +514,8 @@ async def _process_change(
514514
_SDAM_LOGGER,
515515
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
516516
topologyId=self._topology_id,
517-
previousDescription=td_old,
518-
newDescription=self._description,
517+
previousDescription=repr(td_old),
518+
newDescription=repr(self._description),
519519
)
520520

521521
# Shutdown SRV polling for unsupported cluster types.
@@ -581,8 +581,8 @@ async def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
581581
_SDAM_LOGGER,
582582
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
583583
topologyId=self._topology_id,
584-
previousDescription=td_old,
585-
newDescription=self._description,
584+
previousDescription=repr(td_old),
585+
newDescription=repr(self._description),
586586
)
587587

588588
async def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
@@ -747,8 +747,8 @@ async def close(self) -> None:
747747
_SDAM_LOGGER,
748748
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
749749
topologyId=self._topology_id,
750-
previousDescription=old_td,
751-
newDescription=self._description,
750+
previousDescription=repr(old_td),
751+
newDescription=repr(self._description),
752752
)
753753
_debug_log(
754754
_SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id

pymongo/synchronous/topology.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
154154
_SDAM_LOGGER,
155155
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
156156
topologyId=self._topology_id,
157-
previousDescription=initial_td,
158-
newDescription=self._description,
157+
previousDescription=repr(initial_td),
158+
newDescription=repr(self._description),
159159
)
160160

161161
for seed in topology_settings.seeds:
@@ -514,8 +514,8 @@ def _process_change(
514514
_SDAM_LOGGER,
515515
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
516516
topologyId=self._topology_id,
517-
previousDescription=td_old,
518-
newDescription=self._description,
517+
previousDescription=repr(td_old),
518+
newDescription=repr(self._description),
519519
)
520520

521521
# Shutdown SRV polling for unsupported cluster types.
@@ -581,8 +581,8 @@ def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
581581
_SDAM_LOGGER,
582582
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
583583
topologyId=self._topology_id,
584-
previousDescription=td_old,
585-
newDescription=self._description,
584+
previousDescription=repr(td_old),
585+
newDescription=repr(self._description),
586586
)
587587

588588
def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
@@ -745,8 +745,8 @@ def close(self) -> None:
745745
_SDAM_LOGGER,
746746
message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
747747
topologyId=self._topology_id,
748-
previousDescription=old_td,
749-
newDescription=self._description,
748+
previousDescription=repr(old_td),
749+
newDescription=repr(self._description),
750750
)
751751
_debug_log(
752752
_SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id

0 commit comments

Comments
 (0)