Skip to content

Commit dc3e4af

Browse files
authored
Update sections for PHP and Windows compatibility
1 parent 3639e67 commit dc3e4af

File tree

1 file changed

+3
-33
lines changed

1 file changed

+3
-33
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -245,43 +245,13 @@ releasing the `vX.Y` branch as X.Y.Z).
245245

246246
### Ensure PHP version compatibility
247247

248-
Ensure that the extension compiles on PHP 5.6 through the latest PHP 7.x
249-
release. Be sure to test both ZTS and non-ZTS builds for PHP 5.x.
248+
Ensure that the library test suite completes on supported versions of PHP.
250249

251250
### Ensure Windows compatibility
252251

253252
PECL will create Windows DLLs for new releases; however, you must ensure that
254-
the extension successfully builds on Windows before releasing. Note that PHP 5.6
255-
requires VS2012, while PHP 7.x requires VS2015.
256-
257-
Given the following assumptions:
258-
259-
* Build directory is `C:\php-sdk\`
260-
* Compiling for PHP 5.6 (VS2012 x86 Native Tools Command Prompt is running)
261-
* Extension branch checked out in `C:\php-sdk\phpdev\vc11\x86\pecl\mongodb`
262-
263-
The build process will resemble:
264-
265-
```
266-
cd c:\php-sdk\
267-
bin\phpsdk_setvars.bat
268-
269-
cd C:\php-sdk\phpdev\vc11\x86\php-5.6.12-src
270-
nmake clean
271-
buildconf --force
272-
configure --disable-all --with-openssl --enable-cli --enable-json --enable-mongodb=shared --with-mongodb-sasl=yes --with-mongodb-client-side-encryption=yes
273-
nmake
274-
```
275-
276-
If the extension was successfully compiled, a `php_mongodb.dll` file should be
277-
generated in the build directory (e.g. `Release_TS`). You should then verify
278-
that the extension loads and executes properly:
279-
280-
```
281-
cd Release_TS
282-
php.exe -d extension=./php_mongodb.dll -m
283-
php.exe -d extension=./php_mongodb.dll -r "var_dump(new MongoDB\Driver\Manager);"
284-
```
253+
the extension successfully builds on Windows before releasing. Windows builds
254+
are tested by [AppVeyor](.appveyor.yml).
285255

286256
See the [internals wiki](https://wiki.php.net/internals/windows/stepbystepbuild)
287257
for more information.

0 commit comments

Comments
 (0)