[LG-5645] feat(chat-layout): implement ChatMain component #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stephl3
force-pushed
the
steph/chat-layout-main
branch
from
6948c53 to
d1812aa
Compare
|
Size Change: +250 B (+0.02%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/chat-layout-pkg
branch
from
663fa6c to
ae7a9f9
Compare
stephl3
requested review from
adamrasheed and
shaneeza
and removed request for
a team
stephl3
force-pushed
the
steph/chat-layout-main
branch
from
d1812aa to
b7d4136
Compare
stephl3
force-pushed
the
steph/chat-layout-main
branch
from
b7d4136 to
5e4db61
Compare
shaneeza
reviewed
Oct 29, 2025
| expect(screen.getByText('Main Content')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test('forwards HTML attributes to the div element', () => { |
There was a problem hiding this comment.
Do we need to test this?
There was a problem hiding this comment.
Yes, I'm planning to include these in tests from now on to test if HTML attributes are settable. In some cases, our components intentionally don't offer this. It felt worth testing to more explicitly document that ComponentPropsWith*Ref is part of the type interface, and it's a low effort inclusion
shaneeza
reviewed
Oct 29, 2025
| expect(ref.current?.tagName).toBe('DIV'); | ||
| }); | ||
|
|
||
| test('applies custom className', () => { |
There was a problem hiding this comment.
Same for this test. Do we need to test this?
There was a problem hiding this comment.
Yes, I'm planning to test this moving forward as well. It helps document to make sure className is properly passed through to the root node, and it's also a low effort inclusion
shaneeza
reviewed
Oct 29, 2025
|
|
||
| export type ChatMainProps = ComponentPropsWithRef<'div'> & | ||
| DarkModeProps & | ||
| PropsWithChildren<{}>; |
There was a problem hiding this comment.
Should this be required?
There was a problem hiding this comment.
I think we'll also need to omit children from ComponentPropsWithRef
There was a problem hiding this comment.
Dropped this in ChatLayout and ChatMain. For some reason, google + the imported type shows that ComponentProps* doesn't include children, but I guess it actually does
shaneeza
reviewed
Oct 29, 2025
shaneeza
approved these changes
Oct 29, 2025
|
Coverage after merging steph/chat-layout-main into LG-5439/chat-layout will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stephl3
added a commit
that referenced
this pull request
Oct 30, 2025
* feat(chat-layout): implement ChatMain component * refactor(chat-layout): remove PropsWithChildren
stephl3
added a commit
that referenced
this pull request
Nov 4, 2025
* feat(chat-layout): implement ChatMain component * refactor(chat-layout): remove PropsWithChildren
stephl3
added a commit
that referenced
this pull request
Nov 7, 2025
* feat(chat-layout): implement ChatMain component * refactor(chat-layout): remove PropsWithChildren
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR introduces the
ChatMaincomponent to the@lg-chat/chat-layoutpackage, which represents the main content area of the chat layout. The component automatically positions itself in the CSS Grid system and provides a structured container for chat content.Key changes:
ChatMaincomponent with proper TypeScript types, styles, and comprehensive testsChatLayout.stories.tsxwith a complete working example that includes TitleBar, ChatWindow, MessageFeed, Message, and InputBar components@lg-chat/leafygreen-chat-provideras a peer dependency@lg-chat/title-bar,@lg-chat/chat-window,@lg-chat/message-feed,@lg-chat/message,@lg-chat/input-bar) as dev dependencies🎟️ Jira ticket: LG-5645
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Composition/Chat/ChatLayoutpnpm test chat-layoutto verify all ChatMain tests pass