Add RHEL 8, rename "from" to "env"

Author: vector-of-bool

.github/workflows/ci.yml

@@ -23,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        from:
+        env:
           # Alpine
           - alpine:3.19
           - alpine:3.20
@@ -59,23 +59,25 @@ jobs:
           - use_vcpkg=true
         include:
           # Add Almalinux (RHEL) targets, alwasy using vcpkg
-          - { from: almalinux:latest, vcpkg_arg: use_vcpkg=true }
-          - { from: almalinux:10, vcpkg_arg: use_vcpkg=true }
-          # RHEL 9 requires a newer GCC, using the GCC toolset:
-          - { from: almalinux:9 --gts_version=12, vcpkg_arg: use_vcpkg=true }
-          - { from: almalinux:9 --gts_version=13, vcpkg_arg: use_vcpkg=true }
-          - { from: almalinux:9 --gts_version=14, vcpkg_arg: use_vcpkg=true }
+          - { env: almalinux:10, vcpkg_arg: use_vcpkg=true }
+          # RHEL ≤9 requires a newer GCC, using the GCC toolset:
+          - { env: almalinux:9 --gts_version=14, vcpkg_arg: use_vcpkg=true }
+          - { env: almalinux:9 --gts_version=13, vcpkg_arg: use_vcpkg=true }
+          - { env: almalinux:9 --gts_version=12, vcpkg_arg: use_vcpkg=true }
+          # RHEL 8
+          - { env: almalinux:8 --gts_version=13, vcpkg_arg: use_vcpkg=true }
+          - { env: almalinux:8 --gts_version=12, vcpkg_arg: use_vcpkg=true }
     steps:
       - *checkout
       - name: Build
         run: |
           bash tools/earthly.sh +build \
-            --from=${{matrix.from}} \
+            --env=${{matrix.env}} \
             --${{matrix.vcpkg_arg}}
       # This step will use the same cached +build results as long as all Earthly
       # build arguments are equivalent. Make sure of that!
       - name: Test
         run: |
           bash tools/earthly.sh -a +test/results.xml results.xml \
-            --from=${{matrix.from}} \
+            --env=${{matrix.env}} \
             --${{matrix.vcpkg_arg}}

Earthfile

@@ -4,12 +4,12 @@ VERSION 0.8
 ARG --global default_container_registry = "docker.io"
 
 init:
-    ARG --required from
+    ARG --required env
     # Toggle the building of test programs
     ARG test = true
     # Toggle whether we use vcpkg to obtain dependencies
     ARG use_vcpkg = true
-    FROM --pass-args $from
+    FROM --pass-args $env
     DO --pass-args +INSTALL_DEPS
 
 build:
@@ -23,7 +23,7 @@ build:
 test:
     FROM --pass-args +build
     RUN uv run --group=build \
-        make ctest-run TEST_CONFIG=Debug JUNIT_OUTPUT=/results.xml || :
+        make ctest-run TEST_CONFIG=Debug JUNIT_OUTPUT=/results.xml
     SAVE ARTIFACT /results.xml
 
 # Target used to install LLVM for a build. Not used outside this file
@@ -65,7 +65,7 @@ BASE:
         # Install EPEL on RHEL-based platforms
         RUN __install epel-release
     END
-    RUN __install lsb-release && \
+    RUN (__install lsb-release || __install redhat-lsb-core) && \
         (curl --version || __install curl)
 
     # Obtain uv