fix efficiency of QuerySet.bulk_create() #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
requested changes
May 20, 2024
django_mongodb/compiler.py
Outdated
| inserted_id = collection.insert_one(doc, **options).inserted_id | ||
| return [inserted_id] if returning_fields else [] | ||
| inserted_ids = collection.insert_many(docs, **options).inserted_ids | ||
| return [inserted_ids] if returning_fields else [] |
There was a problem hiding this comment.
Suggested change
| return [inserted_ids] if returning_fields else [] | |
| return inserted_ids if returning_fields else [] |
this can just be inserted_ids now since inserted_ids is already a list.
There was a problem hiding this comment.
execute_sql() must return a nested list, and since it no longer accumulates values in keys, this is correct.
django_mongodb/utils.py
Outdated
| @@ -18,3 +24,89 @@ def check_django_compatability(): | |||
| f"You must use the latest version of django-mongodb {A}.{B}.x " | |||
| f"with Django {A}.{B}.y (found django-mongodb {__version__})." | |||
| ) | |||
|
|
|||
|
|
|||
| class CollectionDebugWrapper: | |||
There was a problem hiding this comment.
Is this class part of the PR? It looks to be related to getting debug information.
There was a problem hiding this comment.
As you saw, the first commit is #25. It's a dependency of this PR but I'll merge the other PR first so it'll no longer appear here.
Jibola
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.