Skip to content

Commit d0a67a1

Browse files
authored
fix: bump monaco (#104)
* fix: relax MonacoInstance type constraints for @monaco-editor/react compatibility The MonacoInstance interface had overly specific type constraints for editor.IMarkerSeverity that didn't match the actual Monaco types passed by @monaco-editor/react, causing TypeScript compilation errors in CI. This change makes the optional Monaco namespace properties (editor, MarkerSeverity, KeyMod, KeyCode) more flexible using 'unknown' type, while maintaining type safety for the parts we actually use in setupMonacoCodeCompletion (the languages.typescript API). Fixes TypeScript error: Type error: Argument of type 'typeof import(monaco-editor)' is not assignable to parameter of type 'MonacoInstance'. * chore: update monaco-editor to 0.55.1 and @monaco-editor/react to 4.8.0-rc.3 * doc: update deps * update Changelog
1 parent 1aabdd8 commit d0a67a1

6 files changed

Lines changed: 192 additions & 156 deletions

File tree

@mol-view-stories/lib/deno.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@molstar/mol-view-stories",
3-
"version": "1.0.1",
3+
"version": "1.0.4",
44
"description": "A TypeScript library for working with Molstar molecular viewer stories",
55
"license": "MIT",
66
"exports": {
@@ -37,7 +37,7 @@
3737
},
3838
"imports": {
3939
"@std/assert": "jsr:@std/assert@^1.0.16",
40-
"rollup-plugin-dts": "npm:rollup-plugin-dts@^6.2.1",
40+
"rollup-plugin-dts": "npm:rollup-plugin-dts@^6.3.0",
4141
"molstar/vec3": "npm:molstar@5.5.0/lib/mol-math/linear-algebra/3d/vec3.js",
4242
"molstar/mvs-data": "npm:molstar@5.5.0/lib/extensions/mvs/mvs-data.js",
4343
"molstar/zip": "npm:molstar@5.5.0/lib/mol-util/zip/zip.js",

@mol-view-stories/webapp/CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file, following t
44
## [Unreleased]
55

66
### Added
7+
- Update to latest Monaco with a color picker
78
- **Backend API Service**: REST API backend for storing and managing molecular visualization stories and states
89
- Flask-based service with Pydantic validation and MinIO S3 storage
910
- OIDC authentication, session/state management with metadata handling
@@ -56,4 +57,4 @@ All notable changes to this project will be documented in this file, following t
5657

5758
## [v1.0.0]
5859

59-
- Initial release
60+
- Initial release

@mol-view-stories/webapp/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
"dependencies": {
1515
"@mol-view-stories/lib": "workspace:*",
16-
"@monaco-editor/react": "^4.7.0",
16+
"@monaco-editor/react": "4.8.0-rc.3",
1717
"@radix-ui/react-collapsible": "^1.1.11",
1818
"@radix-ui/react-dialog": "^1.1.14",
1919
"@radix-ui/react-dropdown-menu": "^2.1.15",
@@ -33,7 +33,7 @@
3333
"cmdk": "^1.1.1",
3434
"jotai": "^2.12.5",
3535
"lucide-react": "^0.511.0",
36-
"monaco-editor": "^0.52.2",
36+
"monaco-editor": "^0.55.1",
3737
"monaco-editor-auto-typings": "^0.4.6",
3838
"next": "^15.5.9",
3939
"next-themes": "^0.4.6",

cli/deno.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
"molstar": "^5.5.0"
1313
},
1414
"devDependencies": {
15-
"@eslint/eslintrc": "^3",
16-
"eslint": "^9",
15+
"@eslint/eslintrc": "^3.3.3",
16+
"eslint": "^9.39.2",
1717
"eslint-config-next": "15.3.2",
18-
"prettier": "^3.5.3",
19-
"typescript": "^5"
18+
"prettier": "^3.7.4",
19+
"typescript": "^5.9.3"
2020
}
2121
}

0 commit comments

Comments
 (0)