Commit d0a67a1
authored
fix: bump monaco (#104)
* fix: relax MonacoInstance type constraints for @monaco-editor/react compatibility
The MonacoInstance interface had overly specific type constraints for
editor.IMarkerSeverity that didn't match the actual Monaco types passed
by @monaco-editor/react, causing TypeScript compilation errors in CI.
This change makes the optional Monaco namespace properties (editor,
MarkerSeverity, KeyMod, KeyCode) more flexible using 'unknown' type,
while maintaining type safety for the parts we actually use in
setupMonacoCodeCompletion (the languages.typescript API).
Fixes TypeScript error:
Type error: Argument of type 'typeof import(monaco-editor)' is not
assignable to parameter of type 'MonacoInstance'.
* chore: update monaco-editor to 0.55.1 and @monaco-editor/react to 4.8.0-rc.3
* doc: update deps
* update Changelog1 parent 1aabdd8 commit d0a67a1
6 files changed
Lines changed: 192 additions & 156 deletions
File tree
- @mol-view-stories
- lib
- webapp
- cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
59 | | - | |
| 60 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
0 commit comments