Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests with invalid date in header are sent successfully #4030

Open
AmTryingMyBest opened this issue Jan 7, 2025 · 0 comments
Open

Requests with invalid date in header are sent successfully #4030

AmTryingMyBest opened this issue Jan 7, 2025 · 0 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@AmTryingMyBest
Copy link

AmTryingMyBest commented Jan 7, 2025

Summary:
Requests sent with invalid date format through the testing toolkit to get Party information endpoint /parties/{Type}/{ID} are sent successfully.

Severity:
Low

Priority:
Low

Expected Behavior
A request with invalid format data in any of the header attributes should fail with a 404 error response as a Bad Request.

Response sample
Note the date attribute within the Callback object

{
  "status": 202,
  "statusText": "Accepted",
  "body": "",
  "headers": {
    "cache-control": "no-cache",
    "content-length": "0",
    "date": "Tue, 07 Jan 2025 13:12:38 GMT",
    "connection": "keep-alive",
    "keep-alive": "timeout=5"
  }
}
Callback
{
  "url": "put /parties/ACCOUNT_ID/27713803912",
  "headers": {
    "content-type": "application/vnd.interoperability.parties+json;version=1.0",
    "date": "randomStringForTesting",
    "x-forwarded-for": "do pariatur consectetur laboris velit",
    "fspiop-source": "greenbankfsp",
    "fspiop-destination": "pinkbankfsp",
    "fspiop-encryption": "eu officia non ipsum qui",
    "fspiop-signature": "est aliqua in occaecat",
    "fspiop-uri": "laborum magna aliqua Excepteur",
    "fspiop-http-method": "PUT",
    "traceparent": "00-aabb3d8b6036b1e44e34a43872c36afb-da5296bbd50412be-30",
    "user-agent": "axios/0.27.2",
    "connection": "keep-alive",
    "traceid": "3b67f281-926d-4ee4-9849-d662af3044d6",
    "content-length": "298",
    "accept-encoding": "gzip, compress, deflate, br",
    "host": "mojaloop-testing-toolkit:4040"
  },
  "body": {
    "party": {
      "partyIdInfo": {
        "partyIdType": "ACCOUNT_ID",
        "partyIdentifier": "27713803912",
        "fspId": "greenbankfsp",
        "partySubIdOrType": "tempor commodo nulla"
      },
      "personalInfo": {
        "complexName": {
          "firstName": "Justin",
          "middleName": "Pierre",
          "lastName": "Trudeau"
        },
        "dateOfBirth": "1971-12-25"
      },
      "name": "Justin Pierre"
    }
  }
}

Specifications

  • Component (if known):
  • Version:
  • Platform:
  • Subsystem:
  • Type of testing: API validation
  • Bug found/raised by: Walter

Notes:

  • Severity when opened: Low
  • Priority when opened: Low
@AmTryingMyBest AmTryingMyBest added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Jan 7, 2025
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Development

No branches or pull requests

2 participants