Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueueReceiver unreliable test #158

Open
moggers87 opened this issue Sep 29, 2021 · 0 comments
Open

QueueReceiver unreliable test #158

moggers87 opened this issue Sep 29, 2021 · 0 comments
Labels
bug tests MIssing or bad tests

Comments

@moggers87
Copy link
Owner

  ======================================================================
  FAIL: test_queue_receiver_sleep (tests.test_server.ServerTestCase)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/runner/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/unittest/mock.py", line 1183, in patched
      return func(*args, **keywargs)
    File "/Users/runner/work/salmon/salmon/tests/test_server.py", line 303, in test_queue_receiver_sleep
      self.assertEqual(sleep_mock.call_count, 2)
  AssertionError: 3 != 2

I feel like I've seen this fail before. Maybe just checking the call count is greater than 0 would be enough to ensure correctness?

@moggers87 moggers87 added bug tests MIssing or bad tests labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tests MIssing or bad tests
Projects
None yet
Development

No branches or pull requests

1 participant