Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getObjectContents() doesn't return file content for binary files #25

Open
Mark-H opened this issue Jun 6, 2022 · 0 comments
Open

getObjectContents() doesn't return file content for binary files #25

Mark-H opened this issue Jun 6, 2022 · 0 comments

Comments

@Mark-H
Copy link

Mark-H commented Jun 6, 2022

https://github.com/modxcms/aws-s3-media-source/blob/master/core/components/awss3mediasource/model/awss3mediasource/awss3mediasource.class.php#L1491

Example is when using this media source with MoreGallery; that will use getObjectContents() to load the image to create thumbnails/crops, however that wont work because images are binary files.

I'm not quite sure why the check on binary files is there to begin with, and have confirmed it works fine when replacing the ternary with just $contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant