Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove sensitive private info from lgnForgotPassSentTpl #141

Open
donShakespeare opened this issue Dec 28, 2018 · 2 comments
Open

Comments

@donShakespeare
Copy link

donShakespeare commented Dec 28, 2018

https://github.com/modxcms/Login/blob/master/core/components/login/elements/chunks/lgnforgotpasssenttpl.chunk.tpl

Something many users might not know is that when you allow the feature "Reset Password" you need to really really really customize this one uncommon tpl

[[!Login? &sentTpl=`lgnForgotPassSentTpl`]]
Otherwise, any lurker can get any user's email address if the lurker knows a username.
The lurker just has to attempt to reset password by given username.

The unusual default HTML of that tpl is something revealing like this...
<p>Your login information has been sent to the email address [[+email]].</p>

@matdave
Copy link

matdave commented Dec 28, 2018

What would be the preferred semantic? If a username or email address matches, we will send an email with the password reset link.?

@donShakespeare
Copy link
Author

This is what I use
<p>Your login information has been sent to the email address associated with your account</p>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants