Skip to content

Commit 2a84b23

Browse files
committed
docs: update TODO with completion status and summary
- Mark all phases as complete - Add summary of changes - Document breaking changes for users
1 parent c4009fb commit 2a84b23

File tree

1 file changed

+22
-6
lines changed

1 file changed

+22
-6
lines changed

TODO.md

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,30 @@ Implement changes based on PR review feedback from https://github.com/modelconte
3535
- [x] Update documentation in `crates/rmcp/src/handler/server/tool.rs` (done in Phase 1)
3636

3737
### Phase 6: Update validation logic
38-
- [ ] Modify validation in `crates/rmcp/src/handler/server/router/tool.rs` to use trait-based schema
39-
- [ ] Ensure validation happens at the right point in the pipeline
38+
- [x] Modify validation in `crates/rmcp/src/handler/server/router/tool.rs` to use trait-based schema (already validates correctly)
39+
- [x] Ensure validation happens at the right point in the pipeline (validates after tool execution)
4040

4141
### Phase 7: Final cleanup
42-
- [ ] Run all tests and fix any failures
43-
- [ ] Update any remaining documentation
44-
- [ ] Ensure all examples compile and run correctly
45-
- [ ] Create migration notes for the breaking change
42+
- [x] Run all tests and fix any failures
43+
- [x] Update any remaining documentation
44+
- [x] Ensure all examples compile and run correctly
45+
- [x] Create migration notes for the breaking change (in commit messages)
46+
47+
## Summary
48+
49+
All phases have been completed successfully:
50+
1. Replaced Structured<T> with Json<T> for structured output
51+
2. Added output_schema() method to IntoCallToolResult trait
52+
3. Updated macro to detect Json<T> wrapper specifically
53+
4. Added builder methods to Tool struct for setting schemas
54+
5. Updated all examples and tests
55+
6. Validation logic already works correctly
56+
7. All tests pass and code is clean
57+
58+
## Breaking Changes
59+
60+
- `Structured<T>` has been replaced with `Json<T>`. Users must update their code to use `Json<T>` for structured tool outputs.
61+
- The macro now only generates output schemas for `Json<T>` wrapped types, not for generic `Result<T, E>` types.
4662

4763
## Commands to run after each phase:
4864
```bash

0 commit comments

Comments
 (0)