fix: improve error handling in HttpClientSseClientTransport and add test

- Include response body in error messages for better debugging
- Change sendHttpPost return type from HttpResponse<Void> to HttpResponse<String>
- Use BodyHandlers.ofString() instead of discarding response body
- Add testErrorOnBogusMessage test to verify error handling for invalid JSON-RPC messages
- Test validates that malformed messages return 400 status with descriptive error message

Replace #361

Signed-off-by: Christian Tzolov <[email protected]>

Co-authored-by: jkma <[email protected]>

Author: tzolov

mcp/src/main/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransport.java

@@ -424,8 +424,8 @@ public Mono<Void> sendMessage(JSONRPCMessage message) {
 				.flatMap(body -> sendHttpPost(messageEndpointUri, body).handle((response, sink) -> {
 					if (response.statusCode() != 200 && response.statusCode() != 201 && response.statusCode() != 202
 							&& response.statusCode() != 206) {
-						sink.error(new RuntimeException(
-								"Sending message failed with a non-OK HTTP code: " + response.statusCode()));
+						sink.error(new RuntimeException("Sending message failed with a non-OK HTTP code: "
+								+ response.statusCode() + " - " + response.body()));
 					}
 					else {
 						sink.next(response);
@@ -453,15 +453,15 @@ private Mono<String> serializeMessage(final JSONRPCMessage message) {
 		});
 	}
 
-	private Mono<HttpResponse<Void>> sendHttpPost(final String endpoint, final String body) {
+	private Mono<HttpResponse<String>> sendHttpPost(final String endpoint, final String body) {
 		final URI requestUri = Utils.resolveUri(baseUri, endpoint);
 		final HttpRequest request = this.requestBuilder.copy()
 			.uri(requestUri)
 			.POST(HttpRequest.BodyPublishers.ofString(body))
 			.build();
 
 		// TODO: why discard the body?
-		return Mono.fromFuture(httpClient.sendAsync(request, HttpResponse.BodyHandlers.discarding()));
+		return Mono.fromFuture(httpClient.sendAsync(request, HttpResponse.BodyHandlers.ofString()));
 	}
 
 	/**

mcp/src/test/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransportTests.java

@@ -105,6 +105,16 @@ void cleanup() {
 		container.stop();
 	}
 
+	@Test
+	void testErrorOnBogusMessage() {
+		// bogus message
+		JSONRPCRequest bogusMessage = new JSONRPCRequest(null, null, "test-id", Map.of("key", "value"));
+
+		StepVerifier.create(transport.sendMessage(bogusMessage))
+			.verifyErrorMessage(
+					"Sending message failed with a non-OK HTTP code: 400 - Invalid message: {\"id\":\"test-id\",\"params\":{\"key\":\"value\"}}");
+	}
+
 	@Test
 	void testMessageProcessing() {
 		// Create a test message