Skip to content

Commit d0673ba

Browse files
refactor: Use specific SERVER_PORT and CLIENT_PORT env vars
Per PR feedback from cliffhall: - Changed PORT to SERVER_PORT in server/src/index.ts - Changed PORT to CLIENT_PORT in client/bin/client.js - Added parseInt() for CLIENT_PORT consistency - Updated start.js to pass correct env var names This improves clarity by using specific environment variables for server and client ports instead of the generic PORT variable.
1 parent fe2c5c7 commit d0673ba

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

client/bin/client.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const server = http.createServer((request, response) => {
3939
return handler(request, response, handlerOptions);
4040
});
4141

42-
const port = process.env.PORT || 6274;
42+
const port = parseInt(process.env.CLIENT_PORT || "6274", 10);
4343
const host = process.env.HOST || "localhost";
4444
server.on("listening", () => {
4545
console.log(

client/bin/start.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ async function startDevServer(serverOptions) {
3131
cwd: resolve(__dirname, "../..", "server"),
3232
env: {
3333
...process.env,
34-
PORT: SERVER_PORT,
34+
SERVER_PORT: SERVER_PORT,
3535
CLIENT_PORT: CLIENT_PORT,
3636
MCP_PROXY_TOKEN: sessionToken,
3737
MCP_ENV_VARS: JSON.stringify(envVars),
@@ -90,7 +90,7 @@ async function startProdServer(serverOptions) {
9090
{
9191
env: {
9292
...process.env,
93-
PORT: SERVER_PORT,
93+
SERVER_PORT: SERVER_PORT,
9494
CLIENT_PORT: CLIENT_PORT,
9595
MCP_PROXY_TOKEN: sessionToken,
9696
MCP_ENV_VARS: JSON.stringify(envVars),
@@ -115,7 +115,7 @@ async function startDevClient(clientOptions) {
115115

116116
const client = spawn(clientCommand, clientArgs, {
117117
cwd: resolve(__dirname, ".."),
118-
env: { ...process.env, PORT: CLIENT_PORT },
118+
env: { ...process.env, CLIENT_PORT: CLIENT_PORT },
119119
signal: abort.signal,
120120
echoOutput: true,
121121
});
@@ -163,7 +163,7 @@ async function startProdClient(clientOptions) {
163163
}
164164

165165
await spawnPromise("node", [inspectorClientPath], {
166-
env: { ...process.env, PORT: CLIENT_PORT },
166+
env: { ...process.env, CLIENT_PORT: CLIENT_PORT },
167167
signal: abort.signal,
168168
echoOutput: true,
169169
});

server/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ app.get("/config", originValidationMiddleware, authMiddleware, (req, res) => {
528528
}
529529
});
530530

531-
const PORT = parseInt(process.env.PORT || "6277", 10);
531+
const PORT = parseInt(process.env.SERVER_PORT || "6277", 10);
532532
const HOST = process.env.HOST || "localhost";
533533

534534
const server = app.listen(PORT, HOST);

0 commit comments

Comments
 (0)