Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with CarryOn #40

Open
Tschipp opened this issue Nov 21, 2018 · 2 comments
Open

Compatibility with CarryOn #40

Tschipp opened this issue Nov 21, 2018 · 2 comments

Comments

@Tschipp
Copy link

Tschipp commented Nov 21, 2018

Hi, my mod (Carry On) modifies the player's arm rotation, which obviously doesn't work with MoBends installed.
I'm seeing many compat issues on this repo, so maybe it would be smart to add events that allow other mods to modify the player's rotations, just like mods like Obfuscate do it.

@iwoplaza
Copy link
Collaborator

iwoplaza commented Jan 6, 2019

Hello Tschip.
Right now I'm working on an addon system, which will hopefully allow us to resolve this incompatibility 😄. Looking at how it's implemented right now, there are two ways we could make it compatible:

  1. Make it dependent on Mo' Bends, which probably isn't ideal on your end.
  2. Make an addon-mod which would be added by the user if he wants compatibility with both mods installed.

There could be a third option, where you'd include a not-yet-existing library, which would allow you to modify Mo' Bends models if it's installed. If it's not, the library would just not do anything. I have to think about how I would go about implementing that though.

For now though, I think that the addon system will allow for a lot of increased compatibility with other mods.

@Tschipp
Copy link
Author

Tschipp commented Jan 10, 2019

Hey, an addon mod sounds doable but is a bit inconvenient for the user. I think many mods would profit if you made a simple API, like maybe also just a few events that are fired before rendering that other mods could intercept and modify. I'm not sure how your code looks, but I think something like that could be implemented quite easily. I currently don't have much time on my hands, so the compat isn't a priority for me right now, but I will look at it when I get the chance to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants