Skip to content

Commit 1b4634b

Browse files
committed
Merge remote-tracking branch 'origin/pr/64' into compilation-flags
2 parents 2be3178 + 98c6973 commit 1b4634b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
finding a reference counting bug when handling exceptions.
88
- Fixed collation link freeing bug. Thanks to `o3-mini-high` for suggesting the
99
fix without even being prompted (minus-shot).
10+
- Remove `-O2` compiler flag since optimization flags owned by and can conflict
11+
with `ocamlc -config`.
1012

1113
## [5.3.0] - 2025-01-20
1214

lib/config/discover.ml

+2-3
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,8 @@ let split_ws str =
7171
let add_compiler_args ~is_msvc ~cflags ~libs =
7272
let module C = Configurator.V1 in
7373
match is_msvc with
74-
| true -> { C.Pkg_config.cflags = cflags @ [ "/O2" ]; libs }
75-
| false ->
76-
{ C.Pkg_config.cflags = cflags @ [ "-O2"; "-fPIC"; "-DPIC" ]; libs }
74+
| true -> { C.Pkg_config.cflags; libs }
75+
| false -> { C.Pkg_config.cflags = cflags @ [ "-fPIC"; "-DPIC" ]; libs }
7776

7877
let () =
7978
let module C = Configurator.V1 in

0 commit comments

Comments
 (0)