Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non regression tests #198

Open
4 of 7 tasks
rom1504 opened this issue Nov 3, 2022 · 11 comments
Open
4 of 7 tasks

Add non regression tests #198

rom1504 opened this issue Nov 3, 2022 · 11 comments

Comments

@rom1504
Copy link
Collaborator

rom1504 commented Nov 3, 2022

To make it easier to merge PRs in the future, we need automated non regression tests

  • In GitHub action
  • on CPU

Tests to have:

  • exact inference result before/after
    • non crashing inference
    • non reg : wip at 199
  • can still load with torch.load
  • training works the same before after, for one step, same weights and results
    • non crashing training
    • non reg
@rom1504
Copy link
Collaborator Author

rom1504 commented Nov 3, 2022

@iopho if you want to help here, it would be appreciated

@lopho
Copy link
Contributor

lopho commented Nov 3, 2022

I made some time tomorrow and will start writing tests.

@lopho
Copy link
Contributor

lopho commented Nov 4, 2022

@rom1504 I opened a PR draft for inference testing #199

rom1504 added a commit that referenced this issue Nov 7, 2022
Only runs the training, no actual check except no crashes.

For #198
rom1504 added a commit that referenced this issue Nov 7, 2022
Only runs the training, no actual check except no crashes.

For #198
rom1504 added a commit that referenced this issue Nov 7, 2022
Only runs the training, no actual check except no crashes.

For #198
@rom1504
Copy link
Collaborator Author

rom1504 commented Nov 7, 2022

non crashing training test done at #203, non reg still to do

@rom1504
Copy link
Collaborator Author

rom1504 commented Nov 12, 2022

Non reg inference tests done, thanks @lopho

Next step here is non reg test for training

@rom1504
Copy link
Collaborator Author

rom1504 commented Nov 23, 2022

Still very much interested by the non reg for training if you feel like continuing work here @lopho
Develoment is still active and if we can make sure we don't break things going forward it will be great

@lopho
Copy link
Contributor

lopho commented Nov 24, 2022

Yes, I'm still working on it. Before training I still have to look into making testing more stable regarding randomness between runs, as I think this will be worse with training tests.

@rom1504
Copy link
Collaborator Author

rom1504 commented Dec 18, 2022

Looks like inference testing is working very well with your new strategy @lopho

Do you want to look into training non reg as well ?

We have a few PRs with significant changes and it would be very helpful if we can be confident that base clip training is still doing exactly the same thing

@rom1504 rom1504 mentioned this issue Dec 18, 2022
@lopho
Copy link
Contributor

lopho commented Dec 18, 2022

Definetly, but I won't have time to until after new years.

@lopho
Copy link
Contributor

lopho commented Jan 24, 2023

I will start working on this again within the next week, unless there is already someone working on it that I am not aware of.

@rom1504
Copy link
Collaborator Author

rom1504 commented Jan 28, 2023

@lopho would be great. We're still in need of more reliability for merging PRs!
Currently doing manual training for validation which is painful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants