Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non regression test + interface guarantees #182

Open
1 of 3 tasks
rom1504 opened this issue Sep 26, 2022 · 1 comment
Open
1 of 3 tasks

Non regression test + interface guarantees #182

rom1504 opened this issue Sep 26, 2022 · 1 comment

Comments

@rom1504
Copy link
Collaborator

rom1504 commented Sep 26, 2022

  • We should guarantee that model class keep working and stay compatible with weights. Add some doc on which model class and which weights.

Also tests that would help:

  • Inference test checking output with a few options (precision, jit or not, models ...)
  • 1 training step with a fixed batch of data, check output

This will allow refactoring with confidence we don't break things

@rom1504
Copy link
Collaborator Author

rom1504 commented Sep 26, 2022

#181 is a start on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant