From a8d6c7f1827b7091853f599d131b587571392afa Mon Sep 17 00:00:00 2001 From: Tai An Date: Wed, 9 Sep 2026 06:04:39 -0700 Subject: [PATCH] fix: NameError 'has_reranker' in e2e-rag single-shot result display evaluate_retrieval_query() references an undefined name has_reranker when print_results=True. single_shot_retrieval.py calls it with print_results=True and the default no_rerank=False, so any single-query lookup with reranking enabled raises NameError before printing reranked results. Use the same reranker-availability check already used earlier in the same function (around line 144) instead of the undefined variable. Signed-off-by: Tai An --- e2e-rag/evaluation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e-rag/evaluation.py b/e2e-rag/evaluation.py index 226f7d3d29..4465701702 100644 --- a/e2e-rag/evaluation.py +++ b/e2e-rag/evaluation.py @@ -232,7 +232,7 @@ def evaluate_retrieval_query(rag_db, query: str, expected_urls: List[str], print("-" * 50) # Show reranked results if reranker is available and reranking was used - if not no_rerank and has_reranker: + if not no_rerank and hasattr(rag_db, '_reranker_model') and rag_db._reranker_model is not None: print(f"\nReranking to top-{top_k_reranking}") print(f"Reranking results:")