Skip to content

Commit 2129f0c

Browse files
authored
Bugfix: Fondant base image build (#936)
In `0.12.0` the lightweight component that uses a default image are not working. - During the build of base images the image tag list wasn't initialised correctly within the loop. This means we have overwritten the previous build images. Every base image now contains python version `10.11.9` - We have limited dask to`<2024.3.0`, but only dask `>=2024.4.1` is compatible with python `>=10.11.9`. Limit python version of the base image build.
1 parent c41080a commit 2129f0c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/build_base_image.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,20 @@ while [[ "$#" -gt 0 ]]; do case $1 in
1717
esac; shift; done
1818

1919
# Supported Python versions
20-
python_versions=("3.9" "3.10" "3.11")
20+
python_versions=("3.9" "3.10" "3.11.8")
2121

2222
for tag in "${tags[@]}"; do
2323
for python_version in "${python_versions[@]}"; do
2424
BASENAME=fondant
2525
IMAGE_TAG=${tag}-py${python_version}
2626
full_image_names=()
27-
2827
# create repo if not exists
2928
aws ecr-public describe-repositories --region us-east-1 --repository-names ${BASENAME} || aws ecr-public create-repository --region us-east-1 --repository-name ${BASENAME}
3029
full_image_names+=("public.ecr.aws/fndnt/${BASENAME}:${IMAGE_TAG}")
3130
full_image_names+=("fndnt/${BASENAME}:${IMAGE_TAG}")
3231

3332
# Add argument for each tag
33+
args=()
3434
for image_name in "${full_image_names[@]}" ; do
3535
args+=(-t "$image_name")
3636
done

0 commit comments

Comments
 (0)