Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3 #11

Open
gerardsimons opened this issue Dec 8, 2019 · 2 comments
Open

Upgrade to Python 3 #11

gerardsimons opened this issue Dec 8, 2019 · 2 comments

Comments

@gerardsimons
Copy link
Collaborator

Seeing that Python 2 will sunset January 1st 2020 I think it should be upgraded to Python 3. I am looking into it but unfortunately webapp2 support for Python 3 seems very spotty (GoogleCloudPlatform/webapp2#137).

Should we move to a different platform or can we fix webapp2 for Python 3?

@javdrher
Copy link
Member

javdrher commented Dec 8, 2019

Back when we created the package, there was no Python 3 on App Engine so yes, thanks for bringing this up. We should definately migrate to Python 3.

Regarding webapp2, ML2Grow never uses this framework, it was chosen for this package in order to be more in line with the software available on app engine. Looking at the issue you are referring to, the biggest issue seems to be that no support exists for integrations with other App Engine services (Memcache, firestore etc). We currently use none of these: do we encounter any issues with webapp2 on Python 3? If so, my suggestion is to switch to tornado, this can be accomplished fairly easily.

@gerardsimons
Copy link
Collaborator Author

Cool. I'll try that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants