Merge pull request #23 from AYastrebov/master

mariusc · web-flow · commit 5417bbdc2ff5 · 2017-09-29T09:58:30.000+03:00
Make protocol methods optionsl
diff --git a/Example/Cartfile b/Example/Cartfile
@@ -1 +1 @@
-github "nodes-ios/KeyboardHelper" "swift-3.0"
+github "nodes-ios/KeyboardHelper"
diff --git a/Example/Cartfile.resolved b/Example/Cartfile.resolved
@@ -1 +1 @@
-github "nodes-ios/KeyboardHelper" "58d7c2bf19f7bc93d733290f06ae0eedf03f18a5"
+github "nodes-ios/KeyboardHelper" "1.1.0"
diff --git a/KeyboardHelper/Classes/KeyboardHelper.swift b/KeyboardHelper/Classes/KeyboardHelper.swift
@@ -26,6 +26,11 @@ public protocol KeyboardHelperDelegate: class {
     func keyboardWillDisappear(_ info: KeyboardAppearanceInfo)
 }
 
+/// Hack to make protocol methods optional
+public extension KeyboardHelperDelegate {
+    func keyboardWillAppear(_ info: KeyboardAppearanceInfo) {}
+    func keyboardWillDisappear(_ info: KeyboardAppearanceInfo) {}
+}
 
 /// Useful helper to keep track of keyboard changes.
 public class KeyboardHelper {
diff --git a/KeyboardHelperTests/Tests/KeyboardHelperTests.swift b/KeyboardHelperTests/Tests/KeyboardHelperTests.swift
@@ -43,10 +43,6 @@ class HideSpyDelegate : KeyboardHelperDelegate {
         kai = info
         expectation.fulfill()
     }
-    
-    func keyboardWillAppear(_ info: KeyboardAppearanceInfo) {
-        
-    }
 }
 
 class KeyboardHelperTests: XCTestCase {

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-github "nodes-ios/KeyboardHelper" "swift-3.0"`
	`1`	`+github "nodes-ios/KeyboardHelper"`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-github "nodes-ios/KeyboardHelper" "58d7c2bf19f7bc93d733290f06ae0eedf03f18a5"`
	`1`	`+github "nodes-ios/KeyboardHelper" "1.1.0"`
Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,6 @@ class HideSpyDelegate : KeyboardHelperDelegate {`
`43`	`43`	`kai = info`
`44`	`44`	`expectation.fulfill()`
`45`	`45`	`}`
`46`		`-`
`47`		`- func keyboardWillAppear(_ info: KeyboardAppearanceInfo) {`
`48`		`-`
`49`		`- }`
`50`	`46`	`}`
`51`	`47`
`52`	`48`	`class KeyboardHelperTests: XCTestCase {`