register: aggregation by tags or payee

Author: mkobetic

TODO.md

@@ -1,5 +1,6 @@
 ### Features
 
+- register: aggregate by tags, payee, etc
 - thousand separator in amounts
 - check for account/cc numbers in transactions
 - balance: last reconciled posting date
@@ -24,8 +25,9 @@
 
 ### coin2html
 
-- update user docs in README (details, balances, screenshots ...)
 - allow dropping subaccounts from aggregations (in both chart and register)
+- show reconciliation state in balance view (last reconciled date? vs balance date?)
+- show reconciliation flag in non-aggregated register
 - filter subaccounts, payee, tag...
 - brush to select date range
 - buttons to reset To/From to Min/Max date
@@ -35,6 +37,7 @@
 - tooltips for columns, inputs and wherever useful
 - preserve UI state in history (make back/forward buttons work)
 - trim to time range on export (need to recalc posting balances!)
+- trim to account subtree (need to recalc outer posting balances!)
 - show commodities and prices
 - investment performance summary
 

cmd/coin/register.go

@@ -101,20 +101,22 @@ func (cmd *cmdRegister) execute(f io.Writer) {
 	}
 }
 
-func (cmd *cmdRegister) flatAggregatedRegister(f io.Writer, acc *coin.Account, by *reducer) {
+func (cmd *cmdRegister) flatAggregatedRegister(f io.Writer, acc *coin.Account, by *timeReducer) {
 	totals := accountTotals{}
 	acc.WithChildrenDo(func(a *coin.Account) {
 		ts := totals.newTotals(a, by)
 		for _, p := range cmd.trim(a.Postings) {
-			ts.add(p.Transaction.Posted, p.Quantity)
+			ts.add(p)
 		}
 	})
 	var accounts []*coin.Account
 	totals, accounts = totals.top(cmd.top)
 	top := totals[accounts[0]]
+	// propagate timelines from totals up to top
 	for _, ts := range totals {
-		top.mergeTime(ts)
+		if ts != top { top.mergeTime(ts) }
 	}
+	// propagate full timeline from top down to other totals
 	totals.mergeTime(top)
 	if cmd.cumulative {
 		totals.makeCumulative()
@@ -133,12 +135,12 @@ func (cmd *cmdRegister) flatAggregatedRegister(f io.Writer, acc *coin.Account, b
 	totals.output(f, accounts, label, cmd.output)
 }
 
-func (cmd *cmdRegister) recursiveAggregatedRegister(f io.Writer, acc *coin.Account, by *reducer) {
+func (cmd *cmdRegister) recursiveAggregatedRegister(f io.Writer, acc *coin.Account, by *timeReducer) {
 	totals := accountTotals{}
 	acc.WithChildrenDo(func(a *coin.Account) {
 		ts := totals.newTotals(a, by)
 		for _, p := range cmd.trim(a.Postings) {
-			ts.add(p.Transaction.Posted, p.Quantity)
+			ts.add(p)
 		}
 	})
 	if cmd.recurse {
@@ -176,7 +178,7 @@ func (cmd *cmdRegister) recursiveAggregatedRegister(f io.Writer, acc *coin.Accou
 	totals.output(f, accounts, label, cmd.output)
 }
 
-func (cmd *cmdRegister) period() *reducer {
+func (cmd *cmdRegister) period() *timeReducer {
 	switch {
 	case cmd.weekly:
 		return &week