Trim Phoenix assets and boilerplate

Author: mjc

assets/js/app.js

@@ -15,17 +15,23 @@
 //     import "some-package"
 //
 
-// Include phoenix_html to handle method=PUT/DELETE in forms and buttons.
-import "phoenix_html"
 // Establish Phoenix Socket and LiveView configuration.
 import {Socket} from "phoenix"
 import {LiveSocket} from "phoenix_live_view"
-import topbar from "../vendor/topbar"
 
 let Hooks = {}
 
 const isInitialPageLoadEvent = (event) => event?.detail?.kind === "initial"
 
+window.addEventListener("click", event => {
+  const el = event.target instanceof Element ? event.target.closest("[data-confirm]") : null
+
+  if (el && !window.confirm(el.dataset.confirm)) {
+    event.preventDefault()
+    event.stopImmediatePropagation()
+  }
+}, true)
+
 Hooks.TimezoneHook = {
   mounted() {
     this.setTimezone();
@@ -178,17 +184,6 @@ let liveSocket = new LiveSocket(socketUrl, Socket, {
   hooks: Hooks
 })
 
-// Show progress bar on live navigation and form submits
-topbar.config({barColors: {0: "#29d"}, shadowColor: "rgba(0, 0, 0, .3)"})
-window.addEventListener("phx:page-loading-start", event => {
-  if (isInitialPageLoadEvent(event)) return
-  topbar.show(300)
-})
-window.addEventListener("phx:page-loading-stop", event => {
-  if (isInitialPageLoadEvent(event)) return
-  topbar.hide()
-})
-
 // connect if there are any LiveViews on the page
 liveSocket.connect()
 

assets/vendor/topbar.js

@@ -66,21 +66,12 @@ config :reencodarr, ReencodarrWeb.Endpoint,
   pubsub_server: Reencodarr.PubSub,
   live_view: [signing_salt: "mUVP8kuz"]
 
-# Configures the mailer
-#
-# By default it uses the "Local" adapter which stores the emails
-# locally. You can see the emails in your browser, at "/dev/mailbox".
-#
-# For production it's recommended to configure a different adapter
-# at the `config/runtime.exs`.
-config :reencodarr, Reencodarr.Mailer, adapter: Swoosh.Adapters.Local
-
 # Configure esbuild (the version is required)
 config :esbuild,
   version: "0.17.11",
   reencodarr: [
     args:
-      ~w(js/app.js --bundle --target=es2017 --outdir=../priv/static/assets --external:/fonts/* --external:/images/*),
+      ~w(js/app.js --bundle --target=es2020 --outdir=../priv/static/assets --external:/fonts/* --external:/images/* --legal-comments=none),
     cd: Path.expand("../assets", __DIR__),
     env: %{"NODE_PATH" => Path.expand("../deps", __DIR__)}
   ]

config/config.exs

@@ -72,7 +72,7 @@ config :reencodarr, ReencodarrWeb.Endpoint,
     ]
   ]
 
-# Enable dev routes for dashboard and mailbox
+# Enable dev routes for dashboards
 config :reencodarr, dev_routes: true
 
 # Do not include metadata nor timestamps in development logs
@@ -102,8 +102,5 @@ config :phoenix_live_view,
   # Enable helpful, but potentially expensive runtime checks
   enable_expensive_runtime_checks: true
 
-# Disable swoosh api client as it is only required for production adapters.
-config :swoosh, :api_client, false
-
 # Load local overrides from dev.overrides.exs if exists
 if File.exists?("config/dev.overrides.exs"), do: import_config("dev.overrides.exs")

config/dev.exs

@@ -8,12 +8,6 @@ import Config
 config :reencodarr, ReencodarrWeb.Endpoint,
   cache_static_manifest: "priv/static/cache_manifest.json"
 
-# Configures Swoosh API Client
-config :swoosh, api_client: Swoosh.ApiClient.Finch, finch_name: Reencodarr.Finch
-
-# Disable Swoosh Local Memory Storage
-config :swoosh, local: false
-
 # Do not print debug messages in production
 config :logger, level: :info
 

config/prod.exs

@@ -148,22 +148,4 @@ if config_env() == :prod do
   #       force_ssl: [hsts: true]
   #
   # Check `Plug.SSL` for all available options in `force_ssl`.
-
-  # ## Configuring the mailer
-  #
-  # In production you need to configure the mailer to use a different adapter.
-  # Also, you may need to configure the Swoosh API client of your choice if you
-  # are not using SMTP. Here is an example of the configuration:
-  #
-  #     config :reencodarr, Reencodarr.Mailer,
-  #       adapter: Swoosh.Adapters.Mailgun,
-  #       api_key: System.get_env("MAILGUN_API_KEY"),
-  #       domain: System.get_env("MAILGUN_DOMAIN")
-  #
-  # For this example you need include a HTTP client required by Swoosh API client.
-  # Swoosh supports Hackney and Finch out of the box:
-  #
-  #     config :swoosh, :api_client, Swoosh.ApiClient.Hackney
-  #
-  # See https://hexdocs.pm/swoosh/Swoosh.html#module-installation for details.
 end

config/runtime.exs

@@ -23,16 +23,10 @@ config :reencodarr, ReencodarrWeb.Endpoint,
   secret_key_base: "A4oKjY781OHfIZq4JFru4uL2Z6REsXa7Y+0txG2z4wrWGsYYtMwXv/nFfqnqKTKo",
   server: false
 
-# In test we don't send emails
-config :reencodarr, Reencodarr.Mailer, adapter: Swoosh.Adapters.Test
-
-# Disable swoosh api client as it is only required for production adapters
-config :swoosh, :api_client, false
-
 # Print only warnings and errors during test
 config :logger, level: :warning
 
-# Disable dev routes (LiveDashboard, mailbox preview) during test
+# Disable dev routes during test
 config :reencodarr, dev_routes: false
 
 # Initialize plugs at runtime for faster test compilation

config/test.exs

@@ -107,7 +107,7 @@ defmodule Reencodarr.Application do
       Reencodarr.DbWriter,
       {DNSCluster, query: Application.get_env(:reencodarr, :dns_cluster_query) || :ignore},
       {Phoenix.PubSub, name: Reencodarr.PubSub},
-      # Start the Finch HTTP client for sending emails
+      # Start the Finch HTTP client for outbound API requests.
       {Finch, name: Reencodarr.Finch},
       # Start to serve requests, typically the last entry
       ReencodarrWeb.Endpoint,