Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'The generated kernel accesses more than 8192 arrays' warning compares against 65535 instead #37

Open
expenses opened this issue Nov 22, 2022 · 1 comment

Comments

@expenses
Copy link

0xFFFF is 65535 not 8192 so I'm not entirely sure how to interpret this warning.

drjit-core/src/eval.cpp

Lines 215 to 220 in 847c04b

if (unlikely(kernel_params.size() > 0xFFFF))
jitc_log(Warn,
"jit_run(): The generated kernel accesses more than 8192 "
"arrays (%zu) and will likely not run efficiently. Consider "
"periodically running jit_eval() to break the computation "
"into smaller chunks.", kernel_params.size());

It should be probably either be changed to say 'The generated kernel accesses more than 65535 arrays' or checked against 8192 instead.

I'm getting this when running mitsuba on a very, very large sensor batch: https://github.com/mitsuba-renderer/mitsuba3/blob/master/src/sensors/batch.cpp :D

@wjakob
Copy link
Member

wjakob commented Jul 3, 2023

Tangentially related: the drjit batched sensor was recently redesigned and should no longer have that particular issue (not yet released, but on the master branch if you can compile the renderer on your end)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants