Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LittleEndian.combine should not inline tuple.to_list #34

Closed
andres-erbsen opened this issue Mar 3, 2021 · 3 comments
Closed

LittleEndian.combine should not inline tuple.to_list #34

andres-erbsen opened this issue Mar 3, 2021 · 3 comments

Comments

@andres-erbsen
Copy link
Contributor

LittleEndian.combine should not inline tuple.to_list. It could just take a list as input and have a simpler type.
@samuelgruetter
Copy link
Contributor

Agreed, but on the other hand, the current type allows for concise statements split_combine and combine_split. How about defining a Fixpoint combine_list, and redefining combine in terms of tuple.to_list and combine_list? I think combine is not unfolded too often, so it shouldn't break too many proofs.

@andres-erbsen
Copy link
Contributor Author

Yeah, I like your idea for backwards compat. Perhaps also have _list and _tuple of everything, and maybe even deprecate the unsuffixed version.

@andres-erbsen andres-erbsen mentioned this issue Sep 30, 2021
Open
@andres-erbsen
Copy link
Contributor Author

#44 f9d2d66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andres-erbsen @samuelgruetter