Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the proof verification functions to return errors instead of bools #244

Open
kcalvinalvin opened this issue Jan 9, 2021 · 1 comment

Comments

@kcalvinalvin
Copy link
Member

It's hard to tell what the actual errors were because:

1: Error messages are vague
2: Some functions drop some details about errors (ex. IngestBatchProof() in pollardproof.go)

Changing these functions will help debugging easier

@adiabat
Copy link
Contributor

adiabat commented Jan 11, 2021

Yup, I started doing this in my hashtoknown branch. Not everything yet but definitely agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants