Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a precision to Assets based on coin #22

Open
Rjected opened this issue May 28, 2019 · 0 comments
Open

Add a precision to Assets based on coin #22

Rjected opened this issue May 28, 2019 · 0 comments
Labels
feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization

Comments

@Rjected
Copy link
Collaborator

Rjected commented May 28, 2019

Is your feature request related to a problem? Please describe.
In many places, we use uint64's to represent values of various coins, which for Bitcoin is generally fine, but for other assets which have higher capacities, this may not be the case.
Also, doing floating point arithmetic with coin values should conform to the specific coin's precision.

Describe the solution you'd like
Figure out how to easily create new Assets (maybe do #15 before this one) with a specified precision for arithmetic, then create said arithmetic methods.

Describe alternatives you've considered
N/A

Additional context
N/A

@Rjected Rjected added feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Code necessary for long-term code quality but will involve lots of abstraction & generalization
Projects
None yet
Development

No branches or pull requests

1 participant