feat(app): hot-swap seats - #69
Closed
gorillamoe wants to merge 3 commits into
Closed
Conversation
gorillamoe
force-pushed
the
feat/hotswap-seats
branch
from
December 7, 2024 14:19
4240791 to
d302ad5
Compare
gorillamoe
marked this pull request as draft
December 7, 2024 14:20
gorillamoe
force-pushed
the
feat/hotswap-seats
branch
5 times, most recently
from
December 9, 2024 15:12
0bd4e39 to
2327f2b
Compare
This should be re-usable by both Host and Participant.
gorillamoe
force-pushed
the
feat/hotswap-seats
branch
2 times, most recently
from
December 10, 2024 20:58
8cf99e2 to
7e96bad
Compare
gorillamoe
force-pushed
the
feat/hotswap-seats
branch
from
December 10, 2024 20:59
7e96bad to
6eb4244
Compare
gorillamoe
force-pushed
the
main
branch
2 times, most recently
from
January 22, 2025 19:09
2a81734 to
4b03d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be possible to hot swap seats.
This means, that not only the host should be able to share his screen, but also the participant should be able to request to take over screen sharing.
I think we should start simple and only allow one screen share at a time.
Also: the terms Host and Participant shouldn't change when you request to stream, because it's planned that the Host will be a relay to x-peers; see #48.
Which basically means whoever the Host is, needs a lot of ressources, because he will act as a proxy for all peers.
This closes #47