Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some checks for TableRule definition in admin #21

Open
antisvin opened this issue Apr 26, 2015 · 1 comment
Open

Add some checks for TableRule definition in admin #21

antisvin opened this issue Apr 26, 2015 · 1 comment
Assignees

Comments

@antisvin
Copy link
Collaborator

There's no validation at the moment.

  1. It should run from_yaml/from_json loading, to make sure that rule text is correct
  2. It should check that condtions can be parsed (currently they can be checked by trivial regex).
@antisvin antisvin self-assigned this Apr 26, 2015
@miraculixx
Copy link
Owner

From my POV that's not going to do it. Rather this should be refactoring as described in this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants