Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable TableRule.translations support #20

Open
antisvin opened this issue Apr 24, 2015 · 1 comment
Open

Re enable TableRule.translations support #20

antisvin opened this issue Apr 24, 2015 · 1 comment
Assignees

Comments

@antisvin
Copy link
Collaborator

This doesn't work nicely with #15, since we have a more complex condtions definition and don't run them through eval. We'll end up with something like this:

            {'if': {'conditions': ['am Sonntag', {'das Wetter ist': 'schoen'}]},

I think that we should only support translation for initial strings for NatuarlLanguageRule in #10 , since they are human-readable strings.

@miraculixx
Copy link
Owner

agree to remove for now, doens't make sense with safe "eval"/"action" however let's open a new issue:

I think that we should only support translation for initial strings for NatuarlLanguageRule in #10 , since they are human-readable strings.

Translations shall be possible upon reading the yml for TableRules, logically in the same manner as it was before (though at parse, not at eval time - in the eval case parse/eval was kind of in the same place). From my perspective, this should be refactored such that it can be used for both TableRule and NaturualLanguageRule.

@miraculixx miraculixx assigned antisvin and unassigned miraculixx Apr 26, 2015
@miraculixx miraculixx changed the title Remove TableRule.translations support Re enable TableRule.translations support Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants