Deleting archives does not actually remove them from the cached list of archives

[jeffwidman]

tarsnapper caches the output of tarsnap --list-archives.

So when tarsnapper expires an archives, it also deletes it from the cache:

tarsnapper/tarsnapper/script.py

Line 204 in 1d9f3d3

self.archives.remove(name)

However, self.archives is actually a property, which concatenates two lists and then returns them:

tarsnapper/tarsnapper/script.py

Lines 124 to 125 in 1d9f3d3

	return self._queried_archives + self._known_archives
	archives = property(get_archives)

So the self.archives.remove call is pointless because it only removes the filename from the temporary list created for that specific call to self.archives... it never actually removes the filename from the underlying cache.

[endlessbeing]

Does this mean tarsnapper doesn't actually remove archives from the remote Tarsnap server? That is my experience so far.
tarsnapper returns a list of items being deleted
but nothing seems to have been deleted when I run tarsnap --list-archives

Does it work correctly for anyone else? Am I missing something?

[miracle2k]

@endlessbeing This issue is a bit of a technical peculiarity which should not have any practical effect unless another command is being executed right after "expire" in the same process, which I don't think ever happens.

The deletion should work - I am relying on it myself in production.