Complete assignment

[minhcasi]

Hi /cc @coderschoolreview

I've finish my assignment, please help me to preview.

There are a issue with pull refresh that could blank page, i could not find out the root cause. And the reply inline function have not completed yet :D

[coderschoolreview]

👍 Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

Grading Summary:

• Functionality: Good
• Code Style: Average
• Visual Design: Good
• Usability: Good
• Overall: Good

Detailed Notes

Great things:

• Nice work handling the retweet label by dynamically modifying the constraint. This is a situation where its not possible to specify the behavior that you want solely using Interface Builder.

Some small comments:

• Note that you should resolve all the Auto Layout constraint warnings in your nibs.
• You shoud try setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation. You haven't implement replying from tweet cell, right?
• After I like a tweet, I pull to refresh and your app crashes. I run it again, like tweet, then pull to refresh and it show blank page. After that, I cannot do anything 😣
• You should try implementing the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.
• In ComposeViewController, you should use UITextView instead of UITextField. With UITextField, the long text is only shown on a single line, so you cannot view the whole text.
  
• This white blank is unnecessary. You can show the keyboard immediately when this view appears.
  
• It's a little bit weird when the keyboard is shown and it overlap a half of action buttons. Setting the bottom constraint equal keyboard's height will make it nice 😄
  
• The auto layout for tweet cell works not really well. In the 1st tweet, the avatar overlaps the reply icon, but the 2nd is ok.
  
• Try putting your icon in 2x in Assets.xcassets and see the difference. Your icons will be more clear.
• Please notice my comments in your code to improve your code style.

Good submission overall. This assignment is pretty hard, congrats on completing it! 🌟 It was here to teach you about keeping track of "state" of objects, and also to be the first assignment to accept user input.

[minhcasi]

Thank you /cc @coderschoolreview for great feedbacks and wonderful code preview, that help me a lot, I LOVE YOU GUYS!