Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: optimize search_sorted_pk #38988

Open
1 task done
sunby opened this issue Jan 3, 2025 · 1 comment
Open
1 task done

[Enhancement]: optimize search_sorted_pk #38988

sunby opened this issue Jan 3, 2025 · 1 comment
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@sunby
Copy link
Contributor

sunby commented Jan 3, 2025

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

When we search sorted pks, we do not have to iterate all chunks.
First filter out the chunk that the pk exists in and search it in this chunk.

Why is this needed?

No response

Anything else?

No response

@sunby sunby added the kind/enhancement Issues or changes related to enhancement label Jan 3, 2025
@xiaofan-luan
Copy link
Collaborator

Good catch.

What is the main use case for this? Can we first binary search on chunk first row?
Maybe we should set a index structure for each chunk's first row so we can binary search with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

2 participants