Fix clippy warnings.

Author: yotamofek

src/algorithm/rust_crypto.rs

@@ -54,7 +54,7 @@ where
     }
 
     fn sign(&self, header: &str, claims: &str) -> Result<String, Error> {
-        let hmac = get_hmac_with_data(&self, header, claims);
+        let hmac = get_hmac_with_data(self, header, claims);
         let mac_result = hmac.finalize();
         let code = mac_result.into_bytes();
         Ok(base64::encode_config(&code, base64::URL_SAFE_NO_PAD))
@@ -79,7 +79,7 @@ where
 
     fn verify_bytes(&self, header: &str, claims: &str, signature: &[u8]) -> Result<bool, Error> {
         let hmac = get_hmac_with_data(self, header, claims);
-        hmac.verify_slice(&signature)?;
+        hmac.verify_slice(signature)?;
         Ok(true)
     }
 }
@@ -119,7 +119,7 @@ mod tests {
         let expected_signature = "TJVA95OrM7E2cBab30RMHrHDcEfxjoYZgeFONFh7HgQ";
 
         let signer: Hmac<Sha256> = Hmac::new_from_slice(b"secret")?;
-        let computed_signature = SigningAlgorithm::sign(&signer, &header, &claims)?;
+        let computed_signature = SigningAlgorithm::sign(&signer, header, claims)?;
 
         assert_eq!(computed_signature, expected_signature);
         Ok(())
@@ -133,7 +133,7 @@ mod tests {
 
         let verifier: Hmac<Sha256> = Hmac::new_from_slice(b"secret")?;
         assert!(VerifyingAlgorithm::verify(
-            &verifier, &header, &claims, &signature
+            &verifier, header, claims, signature
         )?);
         Ok(())
     }

src/lib.rs

@@ -144,9 +144,9 @@ impl<H, C, S> Token<H, C, S> {
     }
 }
 
-impl<H, C, S> Into<(H, C)> for Token<H, C, S> {
-    fn into(self) -> (H, C) {
-        (self.header, self.claims)
+impl<H, C, S> From<Token<H, C, S>> for (H, C) {
+    fn from(token: Token<H, C, S>) -> Self {
+        (token.header, token.claims)
     }
 }
 

src/token/signed.rs

@@ -131,9 +131,9 @@ impl<'a, H, C> Token<H, C, Signed> {
     }
 }
 
-impl<H, C> Into<String> for Token<H, C, Signed> {
-    fn into(self) -> String {
-        self.signature.token_string
+impl<H, C> From<Token<H, C, Signed>> for String {
+    fn from(token: Token<H, C, Signed>) -> Self {
+        token.signature.token_string
     }
 }
 

src/token/verified.rs

@@ -247,7 +247,7 @@ mod tests {
 
     // Header   {"alg":"HS512","kid":"second_key"}
     // Claims   {"name":"Jane Doe"}
-    const JANE_DOE_SECOND_KEY_TOKEN: &'static str = "eyJhbGciOiJIUzUxMiIsImtpZCI6InNlY29uZF9rZXkifQ.eyJuYW1lIjoiSmFuZSBEb2UifQ.t2ON5s8DDb2hefBIWAe0jaEcp-T7b2Wevmj0kKJ8BFxKNQURHpdh4IA-wbmBmqtiCnqTGoRdqK45hhW0AOtz0A";
+    const JANE_DOE_SECOND_KEY_TOKEN: &str = "eyJhbGciOiJIUzUxMiIsImtpZCI6InNlY29uZF9rZXkifQ.eyJuYW1lIjoiSmFuZSBEb2UifQ.t2ON5s8DDb2hefBIWAe0jaEcp-T7b2Wevmj0kKJ8BFxKNQURHpdh4IA-wbmBmqtiCnqTGoRdqK45hhW0AOtz0A";
 
     #[test]
     pub fn verify_claims_with_b_tree_map() -> Result<(), Error> {