Skip to content

Commit 9d4153a

Browse files
authored
fix: depends_on and batch request with content collection
2 parents d4a6e2a + 0289e2f commit 9d4153a

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/msgraph_core/requests/batch_request_builder.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,9 @@ async def _post_batch_collection(
105105
raise ValueError("batch_request_content_collection cannot be Null.")
106106

107107
batch_responses = BatchResponseContentCollection()
108-
109-
for batch_request_content in batch_request_content_collection.batches:
110-
request_info = await self.to_post_request_information(batch_request_content)
111-
response = await self._request_adapter.send_async(
112-
request_info, BatchResponseContent, error_map or self.error_map
113-
)
108+
batch_requests = batch_request_content_collection.get_batch_requests_for_execution()
109+
for batch_request_content in batch_requests:
110+
response = await self.post(batch_request_content, error_map)
114111
batch_responses.add_response(response)
115112

116113
return batch_responses

src/msgraph_core/requests/batch_request_content.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def add_request(self, request_id: Optional[str], request: BatchRequestItem) -> N
5252
request.id = str(uuid.uuid4())
5353
if hasattr(request, 'depends_on') and request.depends_on:
5454
for dependent_id in request.depends_on:
55-
if dependent_id not in [req.id for req in self.requests]:
55+
if dependent_id not in self.requests:
5656
dependent_request = self._request_by_id(dependent_id)
5757
if dependent_request:
5858
self._requests[dependent_id] = dependent_request

0 commit comments

Comments
 (0)