Skip to content

configuration-sample extension falsely claims glob support #1144

@Arnatious

Description

@Arnatious

Extension sample

Configuration Example

VS Code version

1.96.4

What went wrong?

Comments and labels in

"description": "Resource configuration: Configure files using glob patterns to have an empty last line always",
and
// 1) Get the configured glob pattern value for the current file
const value: any = vscode.workspace.getConfiguration('', e.uri).get('conf.resource.insertEmptyLastLine');
// 2) Check if the current resource matches the glob pattern
const matches = value ? value[e.fileName] : undefined;
claim that the extension is working with glob patterns, but the extension is just looking up strings in an object, no glob matching happens anywhere.

This also gave me the false impression globs were something exposed to the extension API, which it doesn't seem is the case.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions