eng: More rule updates (#2126)

Author: bwateratmsft

eng/MIGRATION.md

@@ -9,7 +9,7 @@
 1. Run `npm i --save-dev @microsoft/vscode-azext-eng` to install the latest eng package. Bye bye small package-lock.json.
 1. Update your .nvmrc to Node 22+, and update `@types/node` accordingly. The minimum VS Code version for Node 22 is 1.101.0.
    As appropriate, add a minimum VS Code engine version to your package.json as well.
-1. If needed, update `@microsoft/vscode-azext-utils` to 4.0.1 to get the replacements for TestUserInput, TestActionContext, etc.
+1. If needed, update `@microsoft/vscode-azext-utils` to 4.0.2 to get the replacements for TestUserInput, TestActionContext, etc.
 
 # Migrating an NPM package to use this
 This is relatively easy.
@@ -126,7 +126,8 @@ Your tests run in the VS Code extension test host, because **you do have VS Code
     >   - ❌ Variables or other state you expect to be shared
     >
     > To migrate, you may have to rewrite the tests to be more like unit tests, or otherwise, export the necessary
-    > objects from the extension API *but only when running tests*. Use a magic environment variable to control that.
+    > objects from the extension API *but only when running tests*. You can test the `VSCODE_RUNNING_TESTS` env var,
+    > which is set in the base test config.
 1. Also fix other imports as needed.
 1. Create a .vscode-test.mjs file at the root. Read more [here](./src/vscode-test/README.md).
 1. Run the tests. Take note of how many are running, and make sure it's the same as before.

eng/package-lock.json

@@ -1,7 +1,7 @@
 {
     "name": "@microsoft/vscode-azext-eng",
     "author": "Microsoft Corporation",
-    "version": "1.0.0-alpha.2",
+    "version": "1.0.0-alpha.3",
     "description": "Engineering package for Azure extensions for VS Code",
     "repository": {
         "type": "git",

eng/package.json

@@ -45,6 +45,7 @@ export const azExtTestRules: EslintConfig = {
     files: ['**/*.test.ts'],
     rules: {
         '@typescript-eslint/no-explicit-any': 'off', // Allow 'any' in test files
+        '@typescript-eslint/no-non-null-assertion': 'off', // Allow non-null assertions in test files
         '@typescript-eslint/no-unsafe-assignment': 'off', // Allow unsafe assignments in test files
     },
 };

eng/src/eslint/eslintConfigs.ts

@@ -14,6 +14,10 @@ export const baseConfig: Partial<VscodeTestConfig> = {
         require: ['tsx'],
         timeout: 10000,
     },
+    env: {
+        // eslint-disable-next-line @typescript-eslint/naming-convention
+        VSCODE_RUNNING_TESTS: '1',
+    },
 };
 
 /**