Merge pull request #606 from microsoft/dev/aphistra/VSMEF003-generictype-exports

Check exported type for unbound types instead.

Author: AArnott

src/Microsoft.VisualStudio.Composition.Analyzers/VSMEF003ExportTypeMismatchAnalyzer.cs

@@ -155,7 +155,7 @@ private static bool IsTypeCompatible(INamedTypeSymbol implementingType, INamedTy
         // Check if implementing type implements exported interface
         if (exportedType.TypeKind == TypeKind.Interface)
         {
-            return implementingType.AllInterfaces.Any(i => SymbolEqualityComparer.Default.Equals(i.IsGenericType ? i.ConstructUnboundGenericType() : i, exportedType));
+            return implementingType.AllInterfaces.Any(i => SymbolEqualityComparer.Default.Equals(exportedType.IsUnboundGenericType ? i.ConstructUnboundGenericType() : i, exportedType));
         }
 
         return false;

test/Microsoft.VisualStudio.Composition.Analyzers.Tests/VSMEF003ExportTypeMismatchAnalyzerTests.cs

@@ -40,6 +40,33 @@ class Test : ITest
         await VerifyCS.VerifyAnalyzerAsync(test);
     }
 
+    [Fact]
+    public async Task ExportingImplementedMultiTypeInterface_ProducesNoDiagnostic()
+    {
+        string test = """
+            using System.Composition;
+
+            class TestType1
+            {
+            }
+
+            class TestType2
+            {
+            }
+
+            interface ITest<T,V> where T : class where V : class
+            {
+            }
+
+            [Export(typeof(ITest<TestType1,TestType2>))]
+            class Test : ITest<TestType1,TestType2>
+            {
+            }
+            """;
+
+        await VerifyCS.VerifyAnalyzerAsync(test);
+    }
+
     [Fact]
     public async Task ExportingImplementedGenericTypeInterface_ProducesNoDiagnostic()
     {