Merge branch 'gabritto/fix-error-id' of https://github.com/microsoft/typescript-go into gabritto/fix-error-id

Author: Gabriela Araujo Britto

.custom-gcl.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/custom-gcl.jsonschema.json
 
-version: v2.8.0
+version: v2.9.0
 
 destination: ./_tools
 

.devcontainer/devcontainer.json

@@ -28,6 +28,10 @@
         "Install Graphviz": "sudo apt update -y; sudo apt install -y graphviz"
     },
 
+    "containerEnv": {
+        "GOTOOLCHAIN": "auto"
+    },
+
     // Configure tool-specific properties.
     "customizations": {
         "vscode": {

.dprint.jsonc

@@ -38,7 +38,7 @@
         "trailingCommas": "never"
     },
     "gofumpt": {
-        "langVersion": "go1.25",
+        "langVersion": "go1.26",
         "modulePath": "github.com/microsoft/typescript-go"
     },
     "excludes": [

.github/actions/setup-go/action.yml

@@ -4,7 +4,7 @@ description: Setup Go
 inputs:
   go-version:
     description: Go version to set up in go-install.ps1 format
-    default: 'go1.25'
+    default: 'go1.26'
   create:
     description: Create the cache
     default: 'false'

CONTRIBUTING.md

@@ -6,7 +6,7 @@ TypeScript 7.0 will be a key bridge release between TypeScript 6.0 (the [last Ja
 
 ## How to Build and Run
 
-This repo uses [Go 1.25 or higher](https://go.dev/dl/), [Rust 1.88 or higher](https://www.rust-lang.org/tools/install), [Node.js with npm](https://nodejs.org/), and [`hereby`](https://www.npmjs.com/package/hereby).
+This repo uses [Go 1.26 or higher](https://go.dev/dl/), [Rust 1.88 or higher](https://www.rust-lang.org/tools/install), [Node.js with npm](https://nodejs.org/), and [`hereby`](https://www.npmjs.com/package/hereby).
 
 For tests and code generation, this repo contains a git submodule to the main TypeScript repo pointing to the commit being ported.
 When cloning, you'll want to clone with submodules:

_tools/customlint/testdata/go.mod

@@ -1,3 +1,3 @@
 module testdata
 
-go 1.25
+go 1.26

_tools/go.mod

@@ -1,6 +1,6 @@
 module github.com/microsoft/typescript-go/_tools
 
-go 1.25
+go 1.26
 
 require (
 	github.com/golangci/plugin-module-register v0.1.2

go.mod

@@ -1,6 +1,6 @@
 module github.com/microsoft/typescript-go
 
-go 1.25
+go 1.26
 
 require (
 	github.com/Microsoft/go-winio v0.6.2

internal/ast/utilities.go

@@ -3969,7 +3969,7 @@ func HasContextSensitiveParameters(node *Node) bool {
 			// an implicit 'this' parameter which is subject to contextual typing.
 			parameter := core.FirstOrNil(node.Parameters())
 			if parameter == nil || !IsThisParameter(parameter) {
-				return true
+				return node.Flags&NodeFlagsContainsThis != 0
 			}
 		}
 	}

internal/astnav/tokens.go

@@ -394,7 +394,7 @@ func FindPrecedingTokenEx(sourceFile *ast.SourceFile, position int, startNode *a
 						}
 					}
 					if jsDoc != nil {
-						if !excludeJSDoc {
+						if !excludeJSDoc && position < jsDoc.End() {
 							return find(jsDoc)
 						} else {
 							return findRightmostValidToken(jsDoc.End(), sourceFile, n, position, excludeJSDoc)