Remove libsyncrpc and rust related stuff

Author: jakebailey

.devcontainer/devcontainer.json

@@ -13,8 +13,7 @@
         },
         "ghcr.io/devcontainers-extra/features/dprint-asdf:2": {
             "version": "latest"
-        },
-        "ghcr.io/devcontainers/features/rust:1": {}
+        }
     },
 
     // Use 'forwardPorts' to make a list of ports inside the container available locally.

.github/workflows/ci.yml

@@ -32,7 +32,6 @@ jobs:
           dotnet: false
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.
@@ -52,7 +51,6 @@ jobs:
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
 
       - run: npm ci
 
@@ -122,7 +120,6 @@ jobs:
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: 'lts/*'
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.
@@ -213,7 +210,6 @@ jobs:
           dotnet: false
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
         with:
           lint-cache: 'true'
@@ -236,7 +232,6 @@ jobs:
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
 
       - run: npm ci
@@ -258,7 +253,6 @@ jobs:
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: '>=22.16.0'
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
 
       - run: npm ci
@@ -305,7 +299,6 @@ jobs:
         with:
           submodules: true
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
 
       # Avoid duplicate PR annotations.

.github/workflows/copilot-setup-steps.yml

@@ -28,7 +28,6 @@ jobs:
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version: '>=22.16.0'
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
       - uses: ./.github/actions/setup-go
         with:
           lint-cache: 'true'

.github/workflows/create-cache.yml

@@ -47,7 +47,6 @@ jobs:
         with:
           submodules: true
       - uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
-      - uses: dtolnay/rust-toolchain@fcf085fcb4b4b8f63f96906cd713eb52181b5ea4 # stable
 
       - uses: ./.github/actions/setup-go
         with:

CONTRIBUTING.md

@@ -6,7 +6,7 @@ TypeScript 7.0 will be a key bridge release between TypeScript 6.0 (the [last Ja
 
 ## How to Build and Run
 
-This repo uses [Go 1.26 or higher](https://go.dev/dl/), [Rust 1.88 or higher](https://www.rust-lang.org/tools/install), [Node.js with npm](https://nodejs.org/), and [`hereby`](https://www.npmjs.com/package/hereby).
+This repo uses [Go 1.26 or higher](https://go.dev/dl/), [Node.js with npm](https://nodejs.org/), and [`hereby`](https://www.npmjs.com/package/hereby).
 
 For tests and code generation, this repo contains a git submodule to the main TypeScript repo pointing to the commit being ported.
 When cloning, you'll want to clone with submodules:

_packages/api/package.json

@@ -60,7 +60,6 @@
     "dependencies": {
         "@types/node": "^25.2.0",
         "@typescript/ast": "1.0.0",
-        "@typescript/libsyncrpc": "github:microsoft/libsyncrpc#00f42f7e419186ae06c768cb75fff973d95bcaa6",
         "vscode-jsonrpc": "^9.0.0-next.11"
     }
 }

_packages/api/src/api.ts

@@ -15,10 +15,7 @@ import {
     type Type as BaseType,
 } from "./base/api.ts";
 import { ObjectRegistry } from "./base/objectRegistry.ts";
-import {
-    type ChannelType,
-    Client,
-} from "./client.ts";
+import { Client } from "./client.ts";
 import type { FileSystem } from "./fs.ts";
 import { RemoteSourceFile } from "./node.ts";
 import type {
@@ -29,12 +26,11 @@ import type {
 } from "./proto.ts";
 
 export { SymbolFlags, TypeFlags };
-export type { ChannelType, FileIdentifier };
+export type { FileIdentifier };
 export { documentURIToFileName, fileNameToDocumentURI } from "./path.ts";
 
 export interface APIOptions extends BaseAPIOptions {
     fs?: FileSystem;
-    channel?: ChannelType;
 }
 
 /** Type alias for the sync object registry */

_packages/api/src/client.ts

@@ -1,19 +1,15 @@
-import { SyncRpcChannel as NativeSyncRpcChannel } from "@typescript/libsyncrpc";
 import type { FileSystem } from "./fs.ts";
 import { SyncRpcChannel } from "./syncChannel.ts";
 
-export type ChannelType = "js" | "native";
-
 export interface ClientOptions {
     tsserverPath: string;
     cwd?: string;
     logFile?: string;
     fs?: FileSystem;
-    channel?: ChannelType;
 }
 
 export class Client {
-    private channel: SyncRpcChannel | NativeSyncRpcChannel;
+    private channel: SyncRpcChannel;
     private encoder = new TextEncoder();
 
     constructor(options: ClientOptions) {
@@ -28,8 +24,7 @@ export class Client {
             args.push(`--callbacks=${Object.keys(options.fs).join(",")}`);
         }
 
-        const ChannelImpl = options.channel === "native" ? NativeSyncRpcChannel : SyncRpcChannel;
-        this.channel = new ChannelImpl(options.tsserverPath, args);
+        this.channel = new SyncRpcChannel(options.tsserverPath, args);
 
         if (options.fs) {
             for (const [key, callback] of Object.entries(options.fs)) {

_packages/api/test/api.bench.ts

@@ -5,6 +5,5 @@ import { runBenchmarks as runSyncBenchmarks } from "./api.sync.bench.ts";
 const isMain = process.argv[1] === fileURLToPath(import.meta.url);
 if (isMain) {
     await runAsyncBenchmarks();
-    await runSyncBenchmarks({ channel: "js" });
-    await runSyncBenchmarks({ channel: "native" });
+    await runSyncBenchmarks();
 }

_packages/api/test/api.sync.bench.ts

@@ -1,6 +1,5 @@
 import {
     API,
-    type ChannelType,
     type Project,
 } from "@typescript/api";
 import {
@@ -25,14 +24,12 @@ if (isMain) {
 
 export interface SyncBenchmarkOptions {
     singleIteration?: boolean;
-    channel?: ChannelType;
 }
 
 export async function runBenchmarks(options?: boolean | SyncBenchmarkOptions) {
     // Support legacy boolean argument for singleIteration
     const opts: SyncBenchmarkOptions = typeof options === "boolean" ? { singleIteration: options } : (options ?? {});
-    const { singleIteration, channel } = opts;
-    const channelLabel = channel === "native" ? "native" : "js";
+    const { singleIteration } = opts;
 
     const repoRoot = fileURLToPath(new URL("../../../", import.meta.url).toString());
     if (!existsSync(path.join(repoRoot, "_submodules/TypeScript/src/compiler"))) {
@@ -41,7 +38,7 @@ export async function runBenchmarks(options?: boolean | SyncBenchmarkOptions) {
     }
 
     const bench = new Bench({
-        name: `Sync API (${channelLabel})`,
+        name: `Sync API`,
         teardown,
         // Reduce iterations from the default 64 to 10.  Slow tasks
         // (e.g. getSymbolAtLocation over 10k ids at ~450ms each) are
@@ -190,7 +187,6 @@ export async function runBenchmarks(options?: boolean | SyncBenchmarkOptions) {
         api = new API({
             cwd: repoRoot,
             tsserverPath: fileURLToPath(new URL(`../../../built/local/tsgo${process.platform === "win32" ? ".exe" : ""}`, import.meta.url).toString()),
-            channel,
         });
     }
 
@@ -199,7 +195,6 @@ export async function runBenchmarks(options?: boolean | SyncBenchmarkOptions) {
             cwd: repoRoot,
             tsserverPath: fileURLToPath(new URL(`../../../built/local/tsgo${process.platform === "win32" ? ".exe" : ""}`, import.meta.url).toString()),
             fs: createNodeFileSystem(),
-            channel,
         });
     }