Port TS#56182: Include source node inferences in string literal completions deeper in arguments (#2747)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>

Author: Copilot

internal/fourslash/_scripts/failingTests.txt

@@ -556,7 +556,6 @@ TestSignatureHelpCallExpressionJs
 TestSpaceAfterReturn
 TestStringCompletionsImportOrExportSpecifier
 TestStringCompletionsVsEscaping
-TestStringLiteralCompletionsWithinInferredObjectWhenItsKeysAreUsedOutsideOfIt
 TestSuggestionOfUnusedVariableWithExternalModule
 TestSymbolCompletionLowerPriority
 TestSyntheticImportFromBabelGeneratedFile1
@@ -570,7 +569,6 @@ TestTsxQuickInfo5
 TestTsxQuickInfo6
 TestTsxQuickInfo7
 TestTypeCheckAfterResolve
-TestTypeErrorAfterStringCompletionsInNestedCall
 TestTypeOperatorNodeBuilding
 TestUnclosedStringLiteralAutoformating
 TestWhiteSpaceTrimming

internal/fourslash/_scripts/manualTests.txt

@@ -124,3 +124,4 @@ stringLiteralCompletionsInPositionTypedUsingRest
 tripleSlashRefPathCompletionAbsolutePaths
 tripleSlashRefPathCompletionHiddenFile
 tsxCompletion12
+typeErrorAfterStringCompletionsInNestedCall

…terStringCompletionsInNestedCall_test.go …terStringCompletionsInNestedCall_test.gointernal/fourslash/tests/gen/typeErrorAfterStringCompletionsInNestedCall_test.go renamed to internal/fourslash/tests/manual/typeErrorAfterStringCompletionsInNestedCall_test.go internal/fourslash/tests/gen/typeErrorAfterStringCompletionsInNestedCall_test.go renamed to internal/fourslash/tests/manual/typeErrorAfterStringCompletionsInNestedCall_test.go

@@ -10,7 +10,6 @@ import (
 )
 
 func TestTypeErrorAfterStringCompletionsInNestedCall(t *testing.T) {
-	fourslash.SkipIfFailing(t)
 	t.Parallel()
 	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
 	const content = `// @stableTypeOrdering: true
@@ -49,8 +48,8 @@ createMachine<GreetingEvent>({
 		},
 		Items: &fourslash.CompletionsExpectedItems{
 			Exact: []fourslash.CompletionsExpectedItem{
-				"ALOHAx",
 				"ALOHA",
+				"ALOHAx",
 				"LUNCH_TIME",
 				"MORNING",
 			},

internal/ls/string_completions.go

@@ -281,11 +281,13 @@ func (l *LanguageService) getStringLiteralCompletionEntries(
 				fromProperties: stringLiteralCompletionsForObjectLiteral(typeChecker, parent.Parent),
 			}
 		}
-		result := fromContextualType(checker.ContextFlagsCompletions, node, typeChecker)
-		if result != nil {
-			return &stringLiteralCompletions{
-				fromTypes: result,
-			}
+		if ast.FindAncestor(parent.Parent, ast.IsCallLikeExpression) != nil {
+			uniques := &collections.Set[string]{}
+			stringLiteralTypes := append(
+				getStringLiteralTypes(typeChecker.GetContextualType(node, checker.ContextFlagsNone), uniques, typeChecker),
+				getStringLiteralTypes(typeChecker.GetContextualType(node, checker.ContextFlagsCompletions), uniques, typeChecker)...,
+			)
+			return toStringLiteralCompletionsFromTypes(stringLiteralTypes)
 		}
 		return &stringLiteralCompletions{
 			fromTypes: fromContextualType(checker.ContextFlagsNone, node, typeChecker),
@@ -421,7 +423,10 @@ func (l *LanguageService) getStringLiteralCompletionEntries(
 func fromContextualType(contextFlags checker.ContextFlags, node *ast.Node, typeChecker *checker.Checker) *completionsFromTypes {
 	// Get completion for string literal from string literal type
 	// i.e. var x: "hi" | "hello" = "/*completion position*/"
-	types := getStringLiteralTypes(getContextualTypeFromParent(node, typeChecker, contextFlags), nil, typeChecker)
+	return toCompletionsFromTypes(getStringLiteralTypes(getContextualTypeFromParent(node, typeChecker, contextFlags), nil, typeChecker))
+}
+
+func toCompletionsFromTypes(types []*checker.StringLiteralType) *completionsFromTypes {
 	if len(types) == 0 {
 		return nil
 	}
@@ -431,6 +436,16 @@ func fromContextualType(contextFlags checker.ContextFlags, node *ast.Node, typeC
 	}
 }
 
+func toStringLiteralCompletionsFromTypes(types []*checker.StringLiteralType) *stringLiteralCompletions {
+	result := toCompletionsFromTypes(types)
+	if result == nil {
+		return nil
+	}
+	return &stringLiteralCompletions{
+		fromTypes: result,
+	}
+}
+
 func fromUnionableLiteralType(
 	grandparent *ast.Node,
 	parent *ast.Node,