Skip to content

Commit e64ddb3

Browse files
Add DiagnosticSource 6.0.0 to MTP telemetry by @Youssef1313 in #6638 (backport to rel/3.11) (#6639)
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
1 parent 12f254e commit e64ddb3

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

Directory.Packages.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,12 @@
3838
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
3939
</ItemGroup>
4040
<ItemGroup Label="Product dependencies">
41+
<!-- If this gets updated, please revise if the explicit dependency on System.Diagnostics.DiagnosticSource is still needed -->
4142
<PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" />
43+
44+
<!-- This comes transitvely via Microsoft.ApplicationInsights, but we want to upgrade it because 5.0.0 is not maintained -->
45+
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" />
46+
4247
<PackageVersion Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildVersion)" />
4348
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildVersion)" />
4449
<PackageVersion Include="Microsoft.CodeAnalysis" Version="$(MicrosoftCodeAnalysisVersion)" />

src/Platform/Microsoft.Testing.Extensions.Telemetry/Microsoft.Testing.Extensions.Telemetry.csproj

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFrameworks>netstandard2.0;$(MicrosoftTestingTargetFrameworks)</TargetFrameworks>
5+
<NoWarn>$(NoWarn);NU1510</NoWarn>
56
</PropertyGroup>
67

78
<!-- NuGet properties -->
@@ -42,6 +43,10 @@ This package provides telemetry for the platform.]]>
4243

4344
<ItemGroup>
4445
<PackageReference Include="Microsoft.ApplicationInsights" />
46+
47+
<!-- Microsoft.ApplicationInsights already has a dependency on DiagnosticSource. But we want to update the dependency to 6.0.0 instead of 5.0.0 -->
48+
<!-- This is because System.Diagnostics.DiagnosticSource is marked as not maintained -->
49+
<PackageReference Include="System.Diagnostics.DiagnosticSource" />
4550
</ItemGroup>
4651

4752
<ItemGroup>

0 commit comments

Comments
 (0)