From 3227044db7ac0a75b0ecdc669b225cf522cd4c5e Mon Sep 17 00:00:00 2001 From: Michael Fanning Date: Sun, 10 May 2026 12:40:38 -0700 Subject: [PATCH] Drop misleading "partialFingerprints required" check from ADO/GH rules MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The shared base class for the SARIF/ADO/GH "ProvideRequiredResultProperties" validators (Base1015) flagged any result that omitted partialFingerprints as an error against the ADO Advanced Security and GitHub Advanced Security service rule kinds. The message text said the property "is required by the {service} service." That is wrong for both consumers: * Advanced Security for Azure DevOps computes partialFingerprints automatically when the AdvancedSecurity-Publish task ingests a SARIF log that omits them (and Sprint 255 added an explicit opt-in, advancedsecurity.publish.allowmissingpartialfingerprints, for findings that aren't located on source). * GitHub code scanning back-fills partialFingerprints from source when a SARIF log uploaded via the upload-sarif action omits them. They are only recommended for direct REST uploads via /code-scanning/sarifs to avoid duplicate alerts. Producers — particularly AI producers covered by AI2011 — have legitimate reasons to omit partialFingerprints rather than fabricate identity values. This change removes the partialFingerprints check from Base1015 entirely so ADO1015/ADO1017 and GH1015/GH1017 no longer fire on omission. The genuinely-required checks in the same base (message, message.text, locations array, non-empty locations) are preserved. Scope: * Base1015.ProvideRequiredResultProperties.cs — remove the result.PartialFingerprints == null check and its message-resource list entry; add an explanatory comment with the GHAZDO and GH docs citations. * RuleResources.resx / .Designer.cs — remove the Base1015_..._MissingPartialFingerprints_Text resource; remove the "Provide the 'partialFingerprints' dictionary..." sentence from the ADO1015 and GH1015 FullDescription resource strings. * BaselineOption functional-test expected outputs (TEST1001-TEST1008) — regenerated via the test framework's standard rebaseline flow. The diff reflects only the disappearance of Error_MissingPartialFingerprints firings and the corresponding messageStrings / fullDescription text; all other rule firings, baselining behavior, and result counts are preserved. * ReleaseHistory.md — UNRELEASED entry. Verified: full Sarif.Multitool.Library unit suite (90/90) and full Sarif functional suite (118/118) green after the change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- ReleaseHistory.md | 1 + ...ase1015.ProvideRequiredResultProperties.cs | 16 +- .../Rules/RuleResources.Designer.cs | 9 - .../Rules/RuleResources.resx | 11 +- .../TEST1001.ValidateWithBaseline.sarif | 454 +----------------- .../TEST1002.ValidateBaseline.NoResults.sarif | 454 +----------------- ...T1003.ValidateBaseline.AbsentResults.sarif | 454 +----------------- ...TEST1004.ValidateBaseline.NewResults.sarif | 454 +----------------- ...05.ValidateBaseline.UnchangedResults.sarif | 454 +----------------- ...1006.ValidateBaseline.UpdatedResults.sarif | 454 +----------------- ...dateBaseline.LessResultsThanBaseline.sarif | 454 +----------------- ...ST1008.ValidateBaseline.InlineUpdate.sarif | 454 +----------------- 12 files changed, 26 insertions(+), 3643 deletions(-) diff --git a/ReleaseHistory.md b/ReleaseHistory.md index 3dd2a177c..40c03a2ee 100644 --- a/ReleaseHistory.md +++ b/ReleaseHistory.md @@ -1,6 +1,7 @@ # SARIF Package Release History (SDK, Driver, Converters, and Multitool) ## **UNRELEASED** +* BUGFIX: Drop the missing-`partialFingerprints` check from `BaseProvideRequiredResultProperties` (Base1015), which removes the firing for ADO1015/ADO1017 and GH1015/GH1017. Both Advanced Security for Azure DevOps and GitHub code scanning compute `partialFingerprints` automatically when omitted, so the `error`-level "this property is required by the {service} service" message was misleading. See [GHAZDO third-party SARIF docs](https://learn.microsoft.com/azure/devops/repos/security/github-advanced-security-code-scanning-third-party) (Sprint 245 `ruleId` inclusion, Sprint 255 `advancedsecurity.publish.allowmissingpartialfingerprints`) and [GitHub code scanning SARIF support — Fingerprint generation](https://docs.github.com/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#fingerprint-generation). AI producers are already advised against persisting fingerprints by AI2011. * BRK: Rename `Microsoft.CodeAnalysis.Sarif.Multitool.OptionsInterpretter` (and its test class `OptionsInterpretterTests`) to `OptionsInterpreter` / `OptionsInterpreterTests` (single `t`). External callers of `Sarif.Multitool.Library` constructing `new OptionsInterpretter(...)` must update to `new OptionsInterpreter(...)`. * NEW: Add `partition` multitool verb that splits one SARIF log into many by strategy (`PerRule` (default), `PerRunPerRule`, `PerRun`, `PerResult`, `PerRunPerTarget`, `PerRunPerTargetPerRule`, `PerIndexList`). Wraps `SarifPartitioner.Partition`, so each output gets its `tool.driver.rules` and `run.artifacts` pruned to only what the partition references. * NEW: Add `SplittingStrategy.PerIndexList` plus the `--indices` mini-language for explicit per-result bucket assignment: `:,;:...|...`, with bare-int shorthand for run 0 and SARIF URL fallback (`sarif:/runs/X/results/Y`, §3.10.3). Optional `--spillover-bucket NAME` captures uncovered results; `--strict-coverage` errors on uncovered results. Duplicate or out-of-range addresses error. diff --git a/src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs b/src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs index 7df7c8fe6..e5f066a36 100644 --- a/src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs +++ b/src/Sarif.Multitool.Library/Rules/Base1015.ProvideRequiredResultProperties.cs @@ -17,8 +17,7 @@ public class BaseProvideRequiredResultProperties nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_EmptyLocationsArray_Text), nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingLocationsArray_Text), nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingMessageText_Text), - nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingMessage_Text), - nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingPartialFingerprints_Text) + nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingMessage_Text) }; protected ICollection BaseMessageResourceNames => _baseMessageResourceNames; @@ -59,13 +58,12 @@ protected override void Analyze(Result result, string resultPointer) nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_EmptyLocationsArray_Text)); } - if (result.PartialFingerprints == null) - { - // {0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service. - LogResult( - resultPointer, - nameof(RuleResources.Base1015_ProvideRequiredResultProperties_Error_MissingPartialFingerprints_Text)); - } + // Note: missing 'partialFingerprints' is intentionally not flagged. Both consumers covered + // by the ADO and GH rule kinds (Advanced Security for Azure DevOps, GitHub code scanning) + // compute partialFingerprints automatically when the producer omits them. See: + // * https://learn.microsoft.com/azure/devops/repos/security/github-advanced-security-code-scanning-third-party + // * https://docs.github.com/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#fingerprint-generation + // AI producers should also avoid persisting fingerprints (see AI2011). } } } diff --git a/src/Sarif.Multitool.Library/Rules/RuleResources.Designer.cs b/src/Sarif.Multitool.Library/Rules/RuleResources.Designer.cs index 1a7664ffd..e63e4b0fd 100644 --- a/src/Sarif.Multitool.Library/Rules/RuleResources.Designer.cs +++ b/src/Sarif.Multitool.Library/Rules/RuleResources.Designer.cs @@ -318,15 +318,6 @@ internal static string Base1015_ProvideRequiredResultProperties_Error_MissingMes } } - /// - /// Looks up a localized string similar to {0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service.. - /// - internal static string Base1015_ProvideRequiredResultProperties_Error_MissingPartialFingerprints_Text { - get { - return ResourceManager.GetString("Base1015_ProvideRequiredResultProperties_Error_MissingPartialFingerprints_Text", resourceCulture); - } - } - /// /// Looks up a localized string similar to {0}: This 'location' object does not provide a 'physicalLocation' object. This property is required by the {1} service.. /// diff --git a/src/Sarif.Multitool.Library/Rules/RuleResources.resx b/src/Sarif.Multitool.Library/Rules/RuleResources.resx index d6558214a..164fdf642 100644 --- a/src/Sarif.Multitool.Library/Rules/RuleResources.resx +++ b/src/Sarif.Multitool.Library/Rules/RuleResources.resx @@ -525,9 +525,6 @@ Semantics: Assuming the reader of the log file (an end user or another tool) has {0}: The 'message' object on this 'result' object does not provide a 'text' property. This property is required by the {1} service. - - {0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service. - {0}: The 'driver' object in this tool does not provide a 'name' value. This property is required by the {1} service. @@ -591,9 +588,7 @@ Provide the 'ruleId' property, which is the unique identifier of the analysis ru Provide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service. -Provide the 'locations' array, which must contain at least one location object. - -Provide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service. +Provide the 'locations' array, which must contain at least one location object. The Location object is important for providing consumers with the location where the result occurred. @@ -648,9 +643,7 @@ Provide the 'results' array, even if it is empty. Provide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service. -Provide the 'locations' array, which must contain at least one location object. - -Provide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service. +Provide the 'locations' array, which must contain at least one location object. The Location object is important for providing consumers with the location where the result occurred. diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1001.ValidateWithBaseline.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1001.ValidateWithBaseline.sarif index a40bed8cb..90cec68b6 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1001.ValidateWithBaseline.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1001.ValidateWithBaseline.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1002.ValidateBaseline.NoResults.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1002.ValidateBaseline.NoResults.sarif index a40bed8cb..90cec68b6 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1002.ValidateBaseline.NoResults.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1002.ValidateBaseline.NoResults.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1003.ValidateBaseline.AbsentResults.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1003.ValidateBaseline.AbsentResults.sarif index a40bed8cb..90cec68b6 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1003.ValidateBaseline.AbsentResults.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1003.ValidateBaseline.AbsentResults.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1004.ValidateBaseline.NewResults.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1004.ValidateBaseline.NewResults.sarif index cd122f5d8..2546fc701 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1004.ValidateBaseline.NewResults.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1004.ValidateBaseline.NewResults.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1005.ValidateBaseline.UnchangedResults.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1005.ValidateBaseline.UnchangedResults.sarif index cd122f5d8..2546fc701 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1005.ValidateBaseline.UnchangedResults.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1005.ValidateBaseline.UnchangedResults.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1006.ValidateBaseline.UpdatedResults.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1006.ValidateBaseline.UpdatedResults.sarif index 2a004c9b2..4d7841d02 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1006.ValidateBaseline.UpdatedResults.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1006.ValidateBaseline.UpdatedResults.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1007.ValidateBaseline.LessResultsThanBaseline.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1007.ValidateBaseline.LessResultsThanBaseline.sarif index d3a3221d7..ed83d74d2 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1007.ValidateBaseline.LessResultsThanBaseline.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1007.ValidateBaseline.LessResultsThanBaseline.sarif @@ -55,7 +55,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -72,9 +72,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -100,9 +97,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -114,7 +108,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -128,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -159,9 +150,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -199,9 +187,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -404,35 +389,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 3, @@ -462,64 +418,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 4, @@ -549,35 +447,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 5, @@ -607,35 +476,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 6, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 6, @@ -693,35 +533,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 2, @@ -751,35 +562,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 3, @@ -838,35 +620,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 5, @@ -896,64 +649,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 6, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 6, @@ -1011,35 +706,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 2, @@ -1069,35 +735,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 3, @@ -1127,35 +764,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 4, @@ -1185,35 +793,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 5, @@ -1272,35 +851,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 6, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 1 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 7, diff --git a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1008.ValidateBaseline.InlineUpdate.sarif b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1008.ValidateBaseline.InlineUpdate.sarif index a0c56af66..517a4f9c5 100644 --- a/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1008.ValidateBaseline.InlineUpdate.sarif +++ b/src/Test.FunctionalTests.Sarif/TestData/Multitool/BaselineOption/ExpectedOutputs/TEST1008.ValidateBaseline.InlineUpdate.sarif @@ -27,7 +27,7 @@ "id": "ADO1015", "name": "AdoProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the ADO Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'ruleId' property, which is the unique identifier of the analysis rule that was violated. This property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the ADO Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_MissingRuleId": { @@ -44,9 +44,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -72,9 +69,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -86,7 +80,7 @@ "id": "GH1015", "name": "GhasProvideRequiredResultProperties", "fullDescription": { - "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object.\r\n\r\nProvide the 'partialFingerprints' dictionary. This property is required by the GitHub Advanced Security service." + "text": "The Result object represents an analysis finding and should provide details describing the nature of the problem along with its location in the scan target.\r\n\r\nProvide the 'message' property, which is a user-facing explanation of the result occurrence. The message's 'text' property is required by the GitHub Advanced Security service.\r\n\r\nProvide the 'locations' array, which must contain at least one location object." }, "messageStrings": { "Error_EmptyLocationsArray": { @@ -100,9 +94,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -131,9 +122,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -171,9 +159,6 @@ }, "Error_MissingMessage": { "text": "{0}: This 'result' object does not provide a 'message' object. This property is required by the {1} service." - }, - "Error_MissingPartialFingerprints": { - "text": "{0}: This 'result' object does not provide a 'partialFingerprints' dictionary. This property is required by the {1} service." } }, "defaultConfiguration": { @@ -369,35 +354,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -427,64 +383,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -514,35 +412,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -572,35 +441,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[0]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 7, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -658,35 +498,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -716,35 +527,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -803,35 +585,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -861,64 +614,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[1]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 13, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH2012", "ruleIndex": 5, @@ -976,35 +671,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1015", - "ruleIndex": 1, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1015", "ruleIndex": 1, @@ -1034,35 +700,6 @@ "ResultMatching": {} } }, - { - "ruleId": "ADO1017", - "ruleIndex": 2, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "Azure DevOps Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "ADO1017", "ruleIndex": 2, @@ -1092,35 +729,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1015", - "ruleIndex": 3, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1015", "ruleIndex": 3, @@ -1150,35 +758,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH1017", - "ruleIndex": 4, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "GH1017", "ruleIndex": 4, @@ -1237,35 +816,6 @@ "ResultMatching": {} } }, - { - "ruleId": "GH2012", - "ruleIndex": 5, - "level": "error", - "message": { - "id": "Error_MissingPartialFingerprints", - "arguments": [ - "runs[0].results[2]", - "GitHub Advanced Security" - ] - }, - "locations": [ - { - "physicalLocation": { - "artifactLocation": { - "index": 0 - }, - "region": { - "startLine": 19, - "startColumn": 9 - } - } - } - ], - "baselineState": "new", - "properties": { - "ResultMatching": {} - } - }, { "ruleId": "SARIF2002", "ruleIndex": 6,