[Regression]: Download Chromium from custom mirror removes subpath

[sanderlenaerts]

Last Good Version

1.57.0

First Bad Version

1.58.0

Steps to reproduce

We used to download the chromium binary from a host that mirrors the cdn.playwright.dev download host using PLAYWRIGHT_DOWNLOAD_HOST=""

With the update of 1.58.0 the chromium binaries now need to get fetched from /chome-for-testing-public url.
However when passing the PLAYWRIGHT_DOWNLOAD_HOST this path is removed/no longer taken into account

Expected behavior

Passing PLAYWRIGHT_DOWNLOAD_HOST="https://myhost.com" I would expect the chromium binary for mac15-arm64 to be fetched from https://myhost.com/chrome-for-testing-public instead of https://myhost.com

Actual behavior

Passing PLAYWRIGHT_DOWNLOAD_HOST="https://myhost.com" I would expect the chromium binary for mac15-arm64 to be fetched from https://myhost.com/chrome-for-testing-public instead of https://myhost.com

Additional context

Passing PLAYWRIGHT_DOWNLOAD_HOST="https://myhost.com" the chromium binary for mac15-arm64 is fetched from https://myhost.com without /chrome-for-testing-public

Environment

System:
    OS: macOS 15.7.3
    CPU: (12) arm64 Apple M3 Pro
    Memory: 70.73 MB / 36.00 GB
  Binaries:
    Node: 20.19.6
    Yarn: 4.4.0 
    npm: 10.8.2
  IDEs:
    VSCode: 1.98.0 - /opt/homebrew/bin/code
  Languages:
    Bash: 3.2.57 - /bin/bash

[pavelfeldman]

Can you update your mirror and place your Chromium builds under /?

[sanderlenaerts]

Can you update your mirror and place your Chromium builds under /?

Hi @pavelfeldman

We have a mirror https://myhost.com that maps onto https://cdn.playwright.dev. But because of the logic below

playwright/packages/playwright-core/src/server/registry/index.ts

Lines 1260 to 1261 in 39bb726

	if (customHostOverride)
	mirrors = [customHostOverride];

the path /chrome-for-testing-public specified in the cftUrl gets omitted

playwright/packages/playwright-core/src/server/registry/index.ts

Lines 130 to 139 in 39bb726

	function cftUrl(suffix: string): DownloadPathFunction {
	return ({ browserVersion }) => {
	return {
	path: `${browserVersion}/${suffix}`,
	mirrors: [
	'https://cdn.playwright.dev/chrome-for-testing-public',
	],
	};
	};
	}

This evidently results in the Crome binary being fetched from https//myhost.com/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip instead of `https//myhost.com/chrome-for-testing-public/145.0.7632.6/mac-arm64/chrome-mac-arm64.zip

Specifying PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST with the /chrome-for-testing-public path included instead does not offer us a solution as some of our dependent libraries/applications will still be on playwright < 1.58.0

[lukeapage]

We adjusted our path and upgraded but now we have a problem on new machines as the ffmeg download is on a different path so we can’t use one base path for both downloads.

[lukpsaxo]

e.g.

with settings previously:
$Env:PLAYWRIGHT_DOWNLOAD_HOST="https://my-mirror/my-path/dbazure/download/playwright"
error:
https://my-mirror/my-path/dbazure/download/playwright/145.0.7632.6/win64/chrome-headless-shell-win64.zip

with new settings:
$Env:PLAYWRIGHT_DOWNLOAD_HOST="https://my-mirror/my-path/chrome-for-testing-public"
error:
https://my-mirror/my-path/chrome-for-testing-public/builds/ffmpeg/1011/ffmpeg-win64.zip

[pavelfeldman]

There is no question in that the path structure has changed and there is no expectation on our side that this is a non-breaking change. I was wondering why you can't mitigate it via a new proxy with the different path mappings.

[lukeapage]

If you look at my example above - playwright requests base path / ffmpeg and base path / 145… eg it expects both to me present in the same folder. We are proxying the domain as is - but to support playwright we would need a different folder structure from your domain because you are not requesting the full path - you expect ffmeg and chrome for testing in the same folder.

So we tried to jus change the base path but we need to fill in the chrome for testing part of the path since playwright doesn’t add it - but ffmeg is not under the chrome for testing path.

And since ffmeg is cached it only hits new servers.

Sorry it’s hard to explain - hope this made it clearer.

[lukeapage]

For me the right fix is to breaking change it again and add in the path for both components eg either chrome for testing part or dbazure…

[pavelfeldman]

Ack. We are working on it.