Skip to content

Commit f2d4dbc

Browse files
committed
Remove special handling for getSelection() with Firefox from tests
1 parent 834ccff commit f2d4dbc

File tree

3 files changed

+5
-12
lines changed

3 files changed

+5
-12
lines changed

tests/page/elementhandle-select-text.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
2222
const textarea = await page.$('textarea');
2323
await textarea.evaluate(textarea => textarea.value = 'some value');
2424
await textarea.selectText();
25-
if (browserName === 'firefox' || browserName === 'webkit') {
25+
if (browserName === 'webkit') {
2626
expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
2727
expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
2828
} else {
@@ -35,7 +35,7 @@ it('should select input', async ({ page, server, browserName }) => {
3535
const input = await page.$('input');
3636
await input.evaluate(input => input.value = 'some value');
3737
await input.selectText();
38-
if (browserName === 'firefox' || browserName === 'webkit') {
38+
if (browserName === 'webkit') {
3939
expect(await input.evaluate(el => el.selectionStart)).toBe(0);
4040
expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
4141
} else {

tests/page/locator-misc-2.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
7878
const textarea = page.locator('textarea');
7979
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
8080
await textarea.selectText();
81-
if (browserName === 'firefox' || browserName === 'webkit') {
81+
if (browserName === 'webkit') {
8282
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
8383
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
8484
} else {

tests/page/retarget.spec.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
239239
await expect(target).toHaveValue('bar');
240240

241241
await target.selectText();
242-
if (browserName === 'firefox' || browserName === 'webkit') {
242+
if (browserName === 'webkit') {
243243
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
244244
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
245245
} else {
@@ -270,14 +270,7 @@ it('selection retargeting', async ({ page, browserName }) => {
270270
await expect(page.locator('#target')).toHaveText('foo');
271271

272272
await target.selectText();
273-
if (browserName === 'firefox') {
274-
expect(await page.$eval('#target', target => {
275-
const selection = window.getSelection()!;
276-
return selection.anchorNode === target && selection.focusNode === target;
277-
})).toBe(true);
278-
} else {
279-
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
280-
}
273+
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
281274
});
282275
}
283276
});

0 commit comments

Comments
 (0)