Skip to content

Commit c84d00b

Browse files
committed
fix: reject workers=0 and negative values with clear error message
resolveWorkers() previously accepted 0 and negative numbers, causing tests to silently skip with exit code 0. Now throws a descriptive error for any workers value below 1, matching the behavior of forbidOnly (false-positives are caught early). Fixes #39938
1 parent c68820a commit c84d00b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/playwright/src/common/config.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,12 @@ function resolveWorkers(workers: string | number): number {
246246
const parsedWorkers = parseInt(workers, 10);
247247
if (isNaN(parsedWorkers))
248248
throw new Error(`Workers ${workers} must be a number or percentage.`);
249+
if (parsedWorkers < 1)
250+
throw new Error(`Workers must be a positive number, received ${parsedWorkers}.`);
249251
return parsedWorkers;
250252
}
253+
if (workers < 1)
254+
throw new Error(`Workers must be a positive number, received ${workers}.`);
251255
return workers;
252256
}
253257

0 commit comments

Comments
 (0)