feat(soft-assertions): Implement soft assertions for playwright-java #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uchagani
commented
Aug 23, 2023
playwright/src/main/java/com/microsoft/playwright/impl/APIResponseAssertionsImpl.java
Show resolved
Hide resolved
uchagani
commented
Aug 23, 2023
uchagani
commented
Aug 23, 2023
playwright/src/main/java/com/microsoft/playwright/BrowserContext.java
Outdated
Show resolved
Hide resolved
yury-s
approved these changes
Aug 24, 2023
playwright/src/test/java/com/microsoft/playwright/TestSoftAssertions.java
Outdated
Show resolved
Hide resolved
playwright/src/test/java/com/microsoft/playwright/TestSoftLocatorAssertions.java
Show resolved
Hide resolved
|
@yury-s this is ready for another review please. |
yury-s
approved these changes
Aug 25, 2023
|
@uchagani looks good, once the test bots finish we can merge it. Thanks for implementing this! |
|
Docker tests failed because we now need to copy mockito jars similar to these lines. Alternatively, you can skip those tests when running in docker. |
|
@yury-s excluded mockito tests from docker, can i get another approval please |
uchagani
commented
Aug 26, 2023
yury-s
approved these changes
Aug 28, 2023
|
@yury-s do we need to re-run these failures? seems like they only failed on mac and windows but don't look related to my changes |
|
No need to rerun, all look unrelated to your PR, I'll merge it. |
yury-s
added a commit
to yury-s/playwright-java
that referenced
this pull request
Sep 6, 2023
…ht-java (microsoft#1361)" This reverts commit 86f929a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #819