fixing local log writing and attributes

Author: jessk-msft

source/P4VFS.Console/P4VFS.Notes.txt

@@ -1,5 +1,13 @@
 Microsoft P4VFS Release Notes
 
+Version [1.29.1.0]
+* Fixing bug where log output would not be written to the local log file if remote
+  logging was enabled and writting to the remote log file had failed.
+* Fixing undesirable behavior in 1.29.0.0 where all attribute change directory notifications
+  from file hydration were suppressed. This could even prevent windows explorer from
+  showing offline attribute (icon) change without having to refresh. This fix now 
+  allows one attribute change notification when hydration is complete.
+
 Version [1.29.0.0]
 * Fixing virtual file hydration to be excluded from system directory notifications.
   This avoids unecessary FILE_NOTIFY_INFORMATION or DirectoryWatcher events indicating

source/P4VFS.Core/Source/FileOperations.cpp

@@ -1184,13 +1184,14 @@ PopulateFileByStream(
 		return hr;
 	}
 
-	hr = SetFileAttributesOnHandle(dstFile.Handle(), dstFileAttributes & ~(FILE_ATTRIBUTE_OFFLINE));
-	if (FAILED(hr))
+	dstFile.Close();
+
+	if (!SetFileAttributes(fileToPopulate.c_str(), dstFileAttributes & ~(FILE_ATTRIBUTE_OFFLINE)))
 	{
+		hr = HRESULT_FROM_WIN32(GetLastError());
 		return hr;
 	}
 
-	dstFile.Close();
 	return S_OK;
 }
 

source/P4VFS.Core/Source/LogDevice.cpp

@@ -143,13 +143,11 @@ void LogDeviceFile::WriteInternal(time_t time, LogChannel::Enum channel, const S
 
 		if (m_Impersonate.get())
 		{
-			if (FileOperations::ImpersonateFileAppend(ExpandVariables(m_RemoteFilePath).c_str(), line.c_str(), m_Impersonate.get()))
-				return;
+			FileOperations::ImpersonateFileAppend(ExpandVariables(m_RemoteFilePath).c_str(), line.c_str(), m_Impersonate.get());
 		}
 		else
 		{
-			if (FileOperations::FileAppend(ExpandVariables(m_RemoteFilePath).c_str(), line.c_str()))
-				return;
+			FileOperations::FileAppend(ExpandVariables(m_RemoteFilePath).c_str(), line.c_str());
 		}
 	}
 

source/P4VFS.Driver/Include/DriverVersion.h

@@ -4,7 +4,7 @@
 
 #define P4VFS_VER_MAJOR					1			// Increment this number almost never
 #define P4VFS_VER_MINOR					29			// Increment this number whenever the driver changes
-#define P4VFS_VER_BUILD					0			// Increment this number when a major user mode change has been made
+#define P4VFS_VER_BUILD					1			// Increment this number when a major user mode change has been made
 #define P4VFS_VER_REVISION				0			// Increment this number when we rebuild with any change
 
 #define P4VFS_VER_STRINGIZE_EX(v)		L#v