Repo: cleanup some attributes (#2230)

Remove some unneeded attributes, move some around, tweak some to be
cleaner, add some more forbid(unsafe_code)s.

Author: smalis-msft

flowey/flowey_hvlite/src/main.rs

@@ -3,6 +3,8 @@
 
 //! Flowey pipelines used by the OpenVMM project
 
+#![forbid(unsafe_code)]
+
 fn main() {
     flowey_cli::flowey_main::<flowey_hvlite::pipelines::OpenvmmPipelines>(
         "flowey_hvlite",

hyperv/tools/hypestv/src/main.rs

@@ -3,6 +3,8 @@
 
 //! Interactive CLI for Hyper-V VMs.
 
+#![forbid(unsafe_code)]
+
 mod windows;
 
 #[cfg(windows)]

openhcl/ohcldiag-dev/src/main.rs

@@ -5,6 +5,7 @@
 //! guarantees.
 
 #![expect(missing_docs)]
+#![forbid(unsafe_code)]
 
 mod completions;
 

openhcl/openvmm_hcl/src/main.rs

@@ -3,6 +3,8 @@
 
 //! Root binary crate for builds of OpenVMM-HCL.
 
+#![forbid(unsafe_code)]
+
 // Link resources.
 #[cfg(target_os = "linux")]
 use openvmm_hcl_resources as _;

openvmm/openvmm/src/main.rs

@@ -3,6 +3,8 @@
 
 //! Root binary crate for OpenVMM.
 
+#![forbid(unsafe_code)]
+
 // Ensure openvmm_resources gets linked.
 extern crate openvmm_resources as _;
 

petri/petri-tool/src/main.rs

@@ -3,6 +3,8 @@
 
 //! Tool for using petri functionality from the command line.
 
+#![forbid(unsafe_code)]
+
 use anyhow::Context as _;
 use clap::Parser;
 use petri::ArtifactResolver;

petri/pipette/src/agent.rs

@@ -3,8 +3,6 @@
 
 //! The main pipette agent, which is run when the process starts.
 
-#![cfg(any(target_os = "linux", target_os = "windows"))]
-
 use anyhow::Context;
 use futures::future::FutureExt;
 use futures_concurrency::future::RaceOk;

petri/pipette/src/execute.rs

@@ -3,8 +3,6 @@
 
 //! Handler for the execute request.
 
-#![cfg(any(target_os = "linux", target_os = "windows"))]
-
 use futures::executor::block_on;
 use futures::io::AllowStdIo;
 use std::process::Stdio;

petri/pipette/src/main.rs

@@ -4,21 +4,20 @@
 //! This is the petri pipette agent, which runs on the guest and executes
 //! commands and other requests from the host.
 
+#![cfg_attr(not(windows), forbid(unsafe_code))]
+
+#[cfg(any(target_os = "linux", windows))]
 mod agent;
+#[cfg(any(target_os = "linux", windows))]
 mod execute;
+#[cfg(any(target_os = "linux", windows))]
 mod shutdown;
+#[cfg(any(target_os = "linux", windows))]
 mod trace;
 #[cfg(windows)]
 mod winsvc;
 
-// This is here to satisfy rust-analyzer on macos. Pipette does not yet support
-// macos.
-#[cfg(target_os = "macos")]
-fn main() -> anyhow::Result<()> {
-    anyhow::bail!("unsupported on macos")
-}
-
-#[cfg(any(target_os = "linux", target_os = "windows"))]
+#[cfg(any(target_os = "linux", windows))]
 fn main() -> anyhow::Result<()> {
     #[cfg(windows)]
     if std::env::args().nth(1).as_deref() == Some("--service") {
@@ -30,3 +29,8 @@ fn main() -> anyhow::Result<()> {
         agent.run().await
     })
 }
+
+#[cfg(not(any(target_os = "linux", windows)))]
+fn main() -> anyhow::Result<()> {
+    anyhow::bail!("unsupported platform");
+}

petri/pipette/src/shutdown.rs

@@ -3,7 +3,6 @@
 
 //! Handler for the power off request.
 
-#![cfg(any(target_os = "linux", target_os = "windows"))]
 // UNSAFETY: required for Windows shutdown API
 #![cfg_attr(windows, expect(unsafe_code))]